Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability adjust the amount of rooms shown when when room list is collapsed #24286

Open
wapsi opened this issue Jan 22, 2023 · 2 comments
Open

Comments

@wapsi
Copy link

wapsi commented Jan 22, 2023

Your use case

What would you like to do?

It would be nice, if the amount of rooms shown in room list when the list is collapsed can be adjusted from the settings.

Why would you like to do it?

When I'm using Element on my 2K resolution for example, there is enough space to show more rooms than the current, hard-coded amount: 8 rooms is. I've modified it to be 12 for example, and it is better than 8 in my case:

image

How would you like to achieve it?

Now the amount is hard-coded in defaultVisibleTiles, in matrix-react-sdk, and it's not configurable: https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/stores/room-list/ListLayout.ts

    public get defaultVisibleTiles(): number {
        // This number is what "feels right", and mostly subject to design's opinion.
        return 8;
    }

In my opinion, that value should be configurable variable in the settings.

Have you considered any alternatives?

The hard-coded amount has been changed at least once: from 5 rooms to 8, here is the commit: matrix-org/matrix-react-sdk@3f33060 But the ultimate solution would be configurable setting for that.

Additional context

No response

@justjanne
Copy link
Contributor

Just below the "show 32 more" is a drag handle. You should be able to drag that to show as many rooms as you wish to see. The hardcoded number is just a default value.

@wapsi
Copy link
Author

wapsi commented Jan 23, 2023

Yes, you're right! But it resets the size back to the original state (lists only 8 rooms again) if I expand the list and then collapse it again.

So, if that handle is used, then (in my opinion) it should remember the position where it was if the list is first expanded and then collapsed back again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants