Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private MSK wasn't written to 4S after hitting "Reset all" #24484

Open
bwindels opened this issue Feb 10, 2023 · 0 comments
Open

Private MSK wasn't written to 4S after hitting "Reset all" #24484

bwindels opened this issue Feb 10, 2023 · 0 comments
Labels
A-E2EE A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@bwindels
Copy link
Contributor

Steps to reproduce

Background to why I was looking into 4S account data is that I started to work on cross-signing on Hydrogen and saw that on my test account (@bruno4:matrix.org) the m.cross_signing.master 4S key was only encrypted with an old key from a few resets ago. So I wanted to fix that by enable cross signing somehow in Element.

I opened Element and when asked to verify my device after opening Element, I was asked my security key. I entered the one that worked in Hydrogen to enable key backup, but for some reason Element said "That looks wrong". I also used the upload button, that didn't not work.

I proceeded hitting the "Reset all" button. The reset worked but my private MSK in 4S hadn't changed.

After all of this, I have reset just cross-signing which did write the new private MSK to 4S and fixed the situation. Even doing a full reset, I am not able to repro the problem anymore.

Outcome

A full reset to also reinitialize cross-signing

Instead, it didn't seem to do anything for cross-signing, it just reset key backup and 4S

Operating system

Fedora 36

Browser information

Firefox 105

URL for webapp

develop.element.io

Application version

Element version: 087ecc8-react-bb4b07fdc9a6-js-c67325ba07bc Olm version: 3.2.12

Homeserver

No response

Will you send logs?

Yes

@dbkr dbkr added S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-E2EE-Cross-Signing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants