Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a screenshot test for voice message player #24747

Open
luixxiul opened this issue Mar 6, 2023 · 2 comments
Open

Create a screenshot test for voice message player #24747

luixxiul opened this issue Mar 6, 2023 · 2 comments
Labels
A-Voice-Messages T-Task Tasks for the team like planning

Comments

@luixxiul
Copy link

luixxiul commented Mar 6, 2023

Steps to reproduce

  1. Create a PR to fix the current implementation of Player.

Outcome

What did you expect?

There should be a screenshot test for it.

What happened instead?

There is not a test, and a manual review is required.

The lack of a screenshot test has really discouraged us to fix visual bugs of audio player and voice message player.

See: #22541 (comment), matrix-org/matrix-react-sdk#8861 (comment), matrix-org/matrix-react-sdk#8815 (comment), and matrix-org/matrix-react-sdk#8861 (comment)

This area is highly sensitive design wise, so per other PRs I'm intending to take a look before it lands.

It's not ideal that we currently don't have screenshot tests for voice messages.

We have very strict tolerances on the padding/margins for the voice message components though - I'm going to look into adding screenshot tests for this area.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@dbkr dbkr added T-Task Tasks for the team like planning A-Voice-Messages and removed T-Defect labels Mar 7, 2023
@luixxiul
Copy link
Author

luixxiul commented Mar 18, 2023

matrix-org/matrix-react-sdk#10400 lands an initial test of the audio player on FilePanel, although it is not comprehensive.

@luixxiul
Copy link
Author

audio-player.spec.ts has been implemented.

@luixxiul luixxiul changed the title Create a screenshot test for Player of audio file and voice message Create a screenshot test for voice message player Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Voice-Messages T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

2 participants