Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft crashes for legacy calls when call room can't be found #25004

Open
justjanne opened this issue Mar 31, 2023 · 0 comments
Open

Soft crashes for legacy calls when call room can't be found #25004

justjanne opened this issue Mar 31, 2023 · 0 comments
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@justjanne
Copy link
Contributor

justjanne commented Mar 31, 2023

Type: Defect
Related: https://github.com/matrix-org/element-web-rageshakes/issues/20890

LegacyCallView will look up the callRoom, and pass it to LegacyCallViewHeader regardless of if the call could be found or not. If no call could be found, LegacyCallViewHeader will then try to access properties on this non-existing call, causing a soft-crash.

const { call, secondaryCall, pipMode, showApps, onMouseDownOnHeader } = this.props;
const callRoomId = LegacyCallHandler.instance.roomIdForCall(call);
const callRoom = callRoomId ? client.getRoom(callRoomId) : null;
<LegacyCallViewHeader
    onPipMouseDown={onMouseDownOnHeader}
    pipMode={pipMode}
    callRooms={[callRoom, secCallRoom]}
    onMaximize={this.onMaximizeClick}
/>
const [callRoom, onHoldCallRoom] = callRooms;
const callRoomName = callRoom.name;
@justjanne justjanne changed the title Null errors in legacy calls when the call room can't be found Soft crashes for legacy calls when call room can't be found Mar 31, 2023
@andybalaam andybalaam added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-VoIP O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants