Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalink parsing for custom permalink base URL does not work #25038

Closed
weeman1337 opened this issue Apr 5, 2023 · 2 comments
Closed

Permalink parsing for custom permalink base URL does not work #25038

weeman1337 opened this issue Apr 5, 2023 · 2 comments
Labels
A-Matrix.to O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@weeman1337
Copy link
Contributor

Steps to reproduce

  1. Set permalink_prefix to some custom URL like for instance https://example.com
  2. Post a permalink into a room (e.g. https://example.com/#/@fritz:example.com
  3. Look at the message in the room

Outcome

What did you expect?

Permalink pill

What happened instead?

Only plain permalink visible

Operating system

No response

Application version

No response

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@weeman1337 weeman1337 added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Matrix.to O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 5, 2023
@t3chguy
Copy link
Member

t3chguy commented Apr 5, 2023

permalink_prefix is for Element Web style URLs, not matrix.to ones. https://example.com/#/@fritz:example.com is not a valid EW URL fragment

Also you are expecting it to do something it isn't designed to, see config.md, it doesn't say anything about changing parsing

permalink_prefix: An optional URL pointing to an Element Web deployment. For example, https://app.element.io. This will change all permalinks (via the "Share" menus) to point at the Element Web deployment rather than matrix.to.

@t3chguy t3chguy closed this as completed Apr 5, 2023
@weeman1337 weeman1337 mentioned this issue Apr 5, 2023
Closed
@MadLittleMods
Copy link
Contributor

Related to #23960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Matrix.to O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MadLittleMods @t3chguy @weeman1337