Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage shared @keyframe for animations on _animations.pcss #25235

Closed
luixxiul opened this issue Apr 29, 2023 · 2 comments
Closed

Manage shared @keyframe for animations on _animations.pcss #25235

luixxiul opened this issue Apr 29, 2023 · 2 comments

Comments

@luixxiul
Copy link

Your use case

What would you like to do?

Manage shared @keyframe declarations for animations on _animations.pcss.

Why would you like to do it?

To improve and maintain animation consistency, to reduce code fragmentation, and to let developers reuse the existing rules.

How would you like to achieve it?

Look for shared @keyframe declarations, manage them on _animations.pcss

Have you considered any alternatives?

No response

Additional context

It is not clear if every @keyframe declaration should be managed on _animations.pcss.

@luixxiul
Copy link
Author

luixxiul commented Jun 1, 2023

Managing animations on _animations.pcss has been suggested already here: matrix-org/matrix-react-sdk#6454 (comment)

We have _animations.scss, could you move it there instead? I think it'll be much better to keep all the animations stuff in one file, so that we can normalize it in all in the future instead of reinventing the wheel all the time and having different animations in different parts of the app.
Full path: res/css/_animations.scss

@luixxiul
Copy link
Author

The PR was not provided with a review for a couple of month, effectively meaning this is wontfix.

@luixxiul luixxiul closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants