Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate CSS files for obsolete style rules and remove them #25238

Closed
luixxiul opened this issue Apr 30, 2023 · 1 comment
Closed

Investigate CSS files for obsolete style rules and remove them #25238

luixxiul opened this issue Apr 30, 2023 · 1 comment
Labels
A-Developer-Experience Help Wanted Extra attention is needed T-Enhancement

Comments

@luixxiul
Copy link

luixxiul commented Apr 30, 2023 •
edited

Your use case

What would you like to do?

Investigate CSS files for obsolete style rules and remove them.

Why would you like to do it?

With recent PRs (matrix-org/matrix-react-sdk#10733, matrix-org/matrix-react-sdk#10687, matrix-org/matrix-react-sdk#10659, matrix-org/matrix-react-sdk#10550, matrix-org/matrix-react-sdk#10548, matrix-org/matrix-react-sdk#10496, and matrix-org/matrix-react-sdk#10451), I have removed CSS style rules which have been obsolete since several years.

As we do not have a concrete policy or a tool to prevent style rules from becoming obsolete (creating a tracker or linter to detect obsolete rules is indeed unrealistic. see: #25149), I am confident that nobody really knows how much style rules have become obsolete.

Since the rules removed by those PRs have been found just coincidentally, we should be able to detect a lot of obsolete rules if we check CSS files for them intentionally.

How would you like to achieve it?

There is not a tool for automation, therefore, manual labor; investigate each file, remove obsolete rules, create E2E tests if necessary.

Have you considered any alternatives?

I imagine that introducing Compress should reduce a chance of letting rules become obsolete, but it does not detect rules which have already become obsolete, unless it would replace the whole UI, making all of the rules obsolete all at once (which I believe would not happen).

Additional context

No response

For references, here is a list of all CSS files under res/css:

  • ./res/css/components/views/pips/_WidgetPip.pcss
  • ./res/css/components/views/typography/_Caption.pcss
  • ./res/css/components/views/messages/_MBeaconBody.pcss
  • ./res/css/components/views/messages/shared/_MediaProcessingError.pcss
  • ./res/css/components/views/settings/devices/_SecurityRecommendations.pcss
  • ./res/css/components/views/settings/devices/_SelectableDeviceTile.pcss
  • ./res/css/components/views/settings/devices/_FilteredDeviceListHeader.pcss
  • ./res/css/components/views/settings/devices/_DeviceSecurityCard.pcss
  • ./res/css/components/views/settings/devices/_DeviceTypeIcon.pcss
  • ./res/css/components/views/settings/devices/_DeviceTile.pcss
  • ./res/css/components/views/settings/devices/_DeviceDetailHeading.pcss
  • ./res/css/components/views/settings/devices/_DeviceDetails.pcss
  • ./res/css/components/views/settings/devices/_DeviceExpandDetailsButton.pcss
  • ./res/css/components/views/settings/devices/_CurrentDeviceSection.pcss
  • ./res/css/components/views/settings/devices/_FilteredDeviceList.pcss
  • ./res/css/components/views/settings/shared/_SettingsSubsectionHeading.pcss
  • ./res/css/components/views/settings/shared/_SettingsSubsection.pcss
  • ./res/css/components/views/context_menus/_KebabContextMenu.pcss
  • ./res/css/components/views/polls/_PollOption.pcss
  • ./res/css/components/views/spaces/_QuickThemeSwitcher.pcss
  • ./res/css/components/views/beacon/_LiveTimeRemaining.pcss
  • ./res/css/components/views/beacon/_BeaconViewDialog.pcss; checked
  • ./res/css/components/views/beacon/_OwnBeaconStatus.pcss
  • ./res/css/components/views/beacon/_ShareLatestLocation.pcss
  • ./res/css/components/views/beacon/_RoomLiveShareWarning.pcss
  • ./res/css/components/views/beacon/_DialogOwnBeaconStatus.pcss
  • ./res/css/components/views/beacon/_DialogSidebar.pcss
  • ./res/css/components/views/beacon/_BeaconListItem.pcss; checked
  • ./res/css/components/views/beacon/_BeaconStatus.pcss; checked (note class names are generated by this line)
  • ./res/css/components/views/beacon/_LeftPanelLiveShareWarning.pcss
  • ./res/css/components/views/beacon/_StyledLiveBeaconIcon.pcss
  • ./res/css/components/views/beacon/_BeaconStatusTooltip.pcss; checked
  • ./res/css/components/views/elements/_FilterTabGroup.pcss
  • ./res/css/components/views/elements/_FilterDropdown.pcss
  • ./res/css/components/views/elements/_LearnMore.pcss
  • ./res/css/components/views/location/_ShareDialogButtons.pcss
  • ./res/css/components/views/location/_LiveDurationDropdown.pcss
  • ./res/css/components/views/location/_MapError.pcss
  • ./res/css/components/views/location/_ZoomButtons.pcss
  • ./res/css/components/views/location/_Marker.pcss
  • ./res/css/components/views/location/_MapFallback.pcss
  • ./res/css/components/views/location/_ShareType.pcss
  • ./res/css/components/views/location/_LocationShareMenu.pcss
  • ./res/css/components/views/location/_EnableLiveShare.pcss
  • ./res/css/components/views/dialogs/polls/_PollListItemEnded.pcss
  • ./res/css/components/views/dialogs/polls/_PollListItem.pcss
  • ./res/css/components/views/dialogs/polls/_PollDetailHeader.pcss
  • ./res/css/_spacing.pcss
  • ./res/css/_components.pcss
  • ./res/css/structures/_SpaceRoomView.pcss
  • ./res/css/structures/_SearchBox.pcss
  • ./res/css/structures/_ContextualMenu.pcss
  • ./res/css/structures/_NonUrgentToastContainer.pcss
  • ./res/css/structures/_MainSplit.pcss
  • ./res/css/structures/_ToastContainer.pcss
  • ./res/css/structures/_BackdropPanel.pcss
  • ./res/css/structures/_SpacePanel.pcss
  • ./res/css/structures/auth/_SetupEncryptionBody.pcss
  • ./res/css/structures/auth/_CompleteSecurity.pcss
  • ./res/css/structures/auth/_Login.pcss
  • ./res/css/structures/auth/_Registration.pcss
  • ./res/css/structures/_GenericErrorPage.pcss
  • ./res/css/structures/_ViewSource.pcss
  • ./res/css/structures/_SplashPage.pcss
  • ./res/css/structures/_ErrorMessage.pcss
  • ./res/css/structures/_LargeLoader.pcss
  • ./res/css/structures/_RoomStatusBar.pcss
  • ./res/css/structures/_AutocompleteInput.pcss
  • ./res/css/structures/_HomePage.pcss
  • ./res/css/structures/_GenericDropdownMenu.pcss
  • ./res/css/structures/_UserMenu.pcss
  • ./res/css/structures/_AutoHideScrollbar.pcss
  • ./res/css/structures/_RoomView.pcss
  • ./res/css/structures/_LeftPanel.pcss
  • ./res/css/structures/_HeaderButtons.pcss
  • ./res/css/structures/_FileDropTarget.pcss
  • ./res/css/structures/_CompatibilityPage.pcss
  • ./res/css/structures/_SpaceHierarchy.pcss
  • ./res/css/structures/_RightPanel.pcss
  • ./res/css/structures/_MatrixChat.pcss
  • ./res/css/structures/_RoomSearch.pcss
  • ./res/css/structures/_QuickSettingsButton.pcss
  • ./res/css/structures/_ScrollPanel.pcss
  • ./res/css/structures/_TabbedView.pcss
  • ./res/css/structures/_FilePanel.pcss
  • ./res/css/structures/_UploadBar.pcss
  • ./res/css/views/beta/_BetaCard.pcss
  • ./res/css/views/toasts/_AnalyticsToast.pcss
  • ./res/css/views/toasts/_IncomingLegacyCallToast.pcss
  • ./res/css/views/toasts/_NonUrgentEchoFailureToast.pcss
  • ./res/css/views/toasts/_IncomingCallToast.pcss
  • ./res/css/views/room_settings/_AliasSettings.pcss Remove some obsolete CSS rules matrix-org/matrix-react-sdk#10754
  • ./res/css/views/right_panel/_RoomSummaryCard.pcss
  • ./res/css/views/right_panel/_UserInfo.pcss
  • ./res/css/views/right_panel/_VerificationPanel.pcss
  • ./res/css/views/right_panel/_TimelineCard.pcss
  • ./res/css/views/right_panel/_WidgetCard.pcss Remove some obsolete CSS rules matrix-org/matrix-react-sdk#10754
  • ./res/css/views/right_panel/_EncryptionInfo.pcss
  • ./res/css/views/right_panel/_PinnedMessagesCard.pcss
  • ./res/css/views/right_panel/_BaseCard.pcss
  • ./res/css/views/right_panel/_ThreadPanel.pcss
  • ./res/css/views/user-onboarding/_UserOnboardingButton.pcss
  • ./res/css/views/user-onboarding/_UserOnboardingList.pcss
  • ./res/css/views/user-onboarding/_UserOnboardingPage.pcss
  • ./res/css/views/user-onboarding/_UserOnboardingHeader.pcss
  • ./res/css/views/user-onboarding/_UserOnboardingTask.pcss
  • ./res/css/views/emojipicker/_EmojiPicker.pcss
  • ./res/css/views/directory/_NetworkDropdown.pcss
  • ./res/css/views/auth/_AuthButtons.pcss Remove obsolete CSS files - _AuthButtons.pcss, _NewSessionReviewDialog.pcss, and _ManageIntegsButton.pcss matrix-org/matrix-react-sdk#10753
  • ./res/css/views/auth/_CountryDropdown.pcss
  • ./res/css/views/auth/_Welcome.pcss
  • ./res/css/views/auth/_LanguageSelector.pcss
  • ./res/css/views/auth/_InteractiveAuthEntryComponents.pcss
  • ./res/css/views/auth/_AuthHeader.pcss
  • ./res/css/views/auth/_PassphraseField.pcss
  • ./res/css/views/auth/_AuthBody.pcss
  • ./res/css/views/auth/_AuthPage.pcss
  • ./res/css/views/auth/_AuthHeaderLogo.pcss
  • ./res/css/views/auth/_CompleteSecurityBody.pcss
  • ./res/css/views/auth/_LoginWithQR.pcss
  • ./res/css/views/auth/_AuthFooter.pcss
  • ./res/css/views/typography/_Heading.pcss
  • ./res/css/views/rooms/_NewRoomIntro.pcss
  • ./res/css/views/rooms/_SearchBar.pcss
  • ./res/css/views/rooms/wysiwyg_composer/_EditWysiwygComposer.pcss
  • ./res/css/views/rooms/wysiwyg_composer/components/_LinkModal.pcss
  • ./res/css/views/rooms/wysiwyg_composer/components/_FormattingButtons.pcss
  • ./res/css/views/rooms/wysiwyg_composer/components/_Editor.pcss
  • ./res/css/views/rooms/wysiwyg_composer/_SendWysiwygComposer.pcss
  • ./res/css/views/rooms/_BasicMessageComposer.pcss
  • ./res/css/views/rooms/_Autocomplete.pcss
  • ./res/css/views/rooms/_RoomPreviewBar.pcss
  • ./res/css/views/rooms/_ThreadSummary.pcss
  • ./res/css/views/rooms/_RoomUpgradeWarningBar.pcss
  • ./res/css/views/rooms/_Stickers.pcss Remove some obsolete CSS rules matrix-org/matrix-react-sdk#10754
  • ./res/css/views/rooms/_VoiceRecordComposerTile.pcss
  • ./res/css/views/rooms/_MemberInfo.pcss
  • ./res/css/views/rooms/_ReplyTile.pcss
  • ./res/css/views/rooms/_TopUnreadMessagesBar.pcss
  • ./res/css/views/rooms/_EditMessageComposer.pcss
  • ./res/css/views/rooms/_SendMessageComposer.pcss
  • ./res/css/views/rooms/_RoomCallBanner.pcss
  • ./res/css/views/rooms/_EntityTile.pcss
  • ./res/css/views/rooms/_RoomSublist.pcss
  • ./res/css/views/rooms/_EventTile.pcss
  • ./res/css/views/rooms/_RoomTile.pcss
  • ./res/css/views/rooms/_JumpToBottomButton.pcss
  • ./res/css/views/rooms/_AuxPanel.pcss
  • ./res/css/views/rooms/_RoomInfoLine.pcss
  • ./res/css/views/rooms/_LinkPreviewWidget.pcss
  • ./res/css/views/rooms/_LinkPreviewGroup.pcss
  • ./res/css/views/rooms/_RoomHeader.pcss
  • ./res/css/views/rooms/_RoomBreadcrumbs.pcss
  • ./res/css/views/rooms/_PresenceLabel.pcss
  • ./res/css/views/rooms/_MessageComposerFormatBar.pcss
  • ./res/css/views/rooms/_LiveContentSummary.pcss
  • ./res/css/views/rooms/_RoomPreviewCard.pcss
  • ./res/css/views/rooms/_RoomList.pcss Remove some obsolete CSS rules matrix-org/matrix-react-sdk#10754
  • ./res/css/views/rooms/_DecryptionFailureBar.pcss
  • ./res/css/views/rooms/_EventBubbleTile.pcss
  • ./res/css/views/rooms/_AppsDrawer.pcss
  • ./res/css/views/rooms/_WhoIsTypingTile.pcss
  • ./res/css/views/rooms/_NotificationBadge.pcss
  • ./res/css/views/rooms/_PinnedEventTile.pcss
  • ./res/css/views/rooms/_ReplyPreview.pcss
  • ./res/css/views/rooms/_IRCLayout.pcss
  • ./res/css/views/rooms/_RoomListHeader.pcss
  • ./res/css/views/rooms/_MessageComposer.pcss
  • ./res/css/views/rooms/_RecentlyViewedButton.pcss
  • ./res/css/views/rooms/_HistoryTile.pcss
  • ./res/css/views/rooms/_ReadReceiptGroup.pcss
  • ./res/css/views/rooms/_MemberList.pcss
  • ./res/css/views/rooms/_EmojiButton.pcss
  • ./res/css/views/rooms/_E2EIcon.pcss
  • ./res/css/views/verification/_VerificationShowSas.pcss
  • ./res/css/views/terms/_InlineTermsAgreement.pcss
  • ./res/css/views/messages/_MNoticeBody.pcss
  • ./res/css/views/messages/_TextualEvent.pcss
  • ./res/css/views/messages/_MessageActionBar.pcss
  • ./res/css/views/messages/_MVideoBody.pcss
  • ./res/css/views/messages/_ViewSourceEvent.pcss
  • ./res/css/views/messages/_MessageTimestamp.pcss
  • ./res/css/views/messages/_RedactedBody.pcss
  • ./res/css/views/messages/_MImageReplyBody.pcss Remove some obsolete CSS rules matrix-org/matrix-react-sdk#10754
  • ./res/css/views/messages/_MLocationBody.pcss
  • ./res/css/views/messages/_DisambiguatedProfile.pcss
  • ./res/css/views/messages/_MPollBody.pcss
  • ./res/css/views/messages/_MEmoteBody.pcss
  • ./res/css/views/messages/_MFileBody.pcss
  • ./res/css/views/messages/_MPollEndBody.pcss
  • ./res/css/views/messages/_DateSeparator.pcss
  • ./res/css/views/messages/_EventTileBubble.pcss
  • ./res/css/views/messages/_ReactionsRowButton.pcss
  • ./res/css/views/messages/_common_CryptoEvent.pcss
  • ./res/css/views/messages/_CreateEvent.pcss
  • ./res/css/views/messages/_ReactionsRow.pcss
  • ./res/css/views/messages/_MediaBody.pcss
  • ./res/css/views/messages/_HiddenBody.pcss
  • ./res/css/views/messages/_CallEvent.pcss
  • ./res/css/views/messages/_RoomAvatarEvent.pcss
  • ./res/css/views/messages/_MjolnirBody.pcss
  • ./res/css/views/messages/_LegacyCallEvent.pcss
  • ./res/css/views/messages/_MJitsiWidgetEvent.pcss
  • ./res/css/views/messages/_MStickerBody.pcss
  • ./res/css/views/messages/_MImageBody.pcss
  • ./res/css/views/messages/_MTextBody.pcss
  • ./res/css/views/messages/_UnknownBody.pcss
  • ./res/css/views/messages/_JumpToDatePicker.pcss
  • ./res/css/views/messages/_DecryptionFailureBody.pcss
  • ./res/css/views/settings/_CryptographyPanel.pcss
  • ./res/css/views/settings/_PhoneNumbers.pcss
  • ./res/css/views/settings/_AvatarSetting.pcss
  • ./res/css/views/settings/_SetIdServer.pcss
  • ./res/css/views/settings/_ImageSizePanel.pcss
  • ./res/css/views/settings/_SetIntegrationManager.pcss
  • ./res/css/views/settings/_Notifications.pcss
  • ./res/css/views/settings/_SpellCheckLanguages.pcss
  • ./res/css/views/settings/_JoinRuleSettings.pcss
  • ./res/css/views/settings/_ProfileSettings.pcss
  • ./res/css/views/settings/_DevicesPanel.pcss
  • ./res/css/views/settings/tabs/room/_NotificationSettingsTab.pcss
  • ./res/css/views/settings/tabs/room/_RolesRoomSettingsTab.pcss
  • ./res/css/views/settings/tabs/room/_SecurityRoomSettingsTab.pcss
  • ./res/css/views/settings/tabs/room/_GeneralRoomSettingsTab.pcss
  • ./res/css/views/settings/tabs/_SettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_SidebarUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_GeneralUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_AppearanceUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_KeyboardUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_PreferencesUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_MjolnirUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_SecurityUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_HelpUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_VoiceUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/user/_LabsUserSettingsTab.pcss
  • ./res/css/views/settings/tabs/_SettingsSection.pcss
  • ./res/css/views/settings/_CrossSigningPanel.pcss
  • ./res/css/views/settings/_FontScalingPanel.pcss
  • ./res/css/views/settings/_LayoutSwitcher.pcss
  • ./res/css/views/settings/_KeyboardShortcut.pcss
  • ./res/css/views/settings/_UpdateCheckButton.pcss
  • ./res/css/views/settings/_SettingsFieldset.pcss
  • ./res/css/views/settings/_ThemeChoicePanel.pcss
  • ./res/css/views/settings/_SecureBackupPanel.pcss
  • ./res/css/views/settings/_IntegrationManager.pcss
  • ./res/css/views/settings/_EmailAddresses.pcss
  • ./res/css/views/context_menus/_RoomGeneralContextMenu.pcss
  • ./res/css/views/context_menus/_RoomNotificationContextMenu.pcss
  • ./res/css/views/context_menus/_LegacyCallContextMenu.pcss
  • ./res/css/views/context_menus/_MessageContextMenu.pcss
  • ./res/css/views/context_menus/_DeviceContextMenu.pcss
  • ./res/css/views/context_menus/_IconizedContextMenu.pcss
  • ./res/css/views/polls/pollHistory/_PollHistoryList.pcss
  • ./res/css/views/polls/pollHistory/_PollHistory.pcss
  • ./res/css/views/audio_messages/_Waveform.pcss
  • ./res/css/views/audio_messages/_AudioPlayer.pcss
  • ./res/css/views/audio_messages/_SeekBar.pcss
  • ./res/css/views/audio_messages/_PlayPauseButton.pcss
  • ./res/css/views/audio_messages/_PlaybackContainer.pcss
  • ./res/css/views/spaces/_SpaceChildrenPicker.pcss
  • ./res/css/views/spaces/_SpaceCreateMenu.pcss
  • ./res/css/views/spaces/_SpacePublicShare.pcss
  • ./res/css/views/spaces/_SpaceBasicSettings.pcss
  • ./res/css/views/voip/_LegacyCallViewForRoom.pcss
  • ./res/css/views/voip/_LegacyCallViewSidebar.pcss
  • ./res/css/views/voip/_DialPadContextMenu.pcss
  • ./res/css/views/voip/_DialPad.pcss
  • ./res/css/views/voip/_LegacyCallView.pcss
  • ./res/css/views/voip/_LegacyCallPreview.pcss
  • ./res/css/views/voip/LegacyCallView/_LegacyCallViewButtons.pcss
  • ./res/css/views/voip/_CallDuration.pcss
  • ./res/css/views/voip/_VideoFeed.pcss
  • ./res/css/views/voip/_CallView.pcss
  • ./res/css/views/voip/_DialPadModal.pcss
  • ./res/css/views/voip/_LegacyCallViewHeader.pcss
  • ./res/css/views/elements/_ToggleSwitch.pcss
  • ./res/css/views/elements/_RichText.pcss
  • ./res/css/views/elements/_Field.pcss
  • ./res/css/views/elements/_StyledCheckbox.pcss
  • ./res/css/views/elements/_Spinner.pcss
  • ./res/css/views/elements/_UseCaseSelectionButton.pcss
  • ./res/css/views/elements/_ErrorBoundary.pcss
  • ./res/css/views/elements/_InlineSpinner.pcss
  • ./res/css/views/elements/_SearchWarning.pcss
  • ./res/css/views/elements/_SyntaxHighlight.pcss
  • ./res/css/views/elements/_MiniAvatarUploader.pcss
  • ./res/css/views/elements/_RoleButton.pcss
  • ./res/css/views/elements/_TooltipButton.pcss
  • ./res/css/views/elements/_ProgressBar.pcss
  • ./res/css/views/elements/_ServerPicker.pcss
  • ./res/css/views/elements/_Tooltip.pcss
  • ./res/css/views/elements/_GenericEventListSummary.pcss
  • ./res/css/views/elements/_EventTilePreview.pcss
  • ./res/css/views/elements/_DesktopCapturerSourcePicker.pcss
  • ./res/css/views/elements/_TagComposer.pcss
  • ./res/css/views/elements/_PowerSelector.pcss
  • ./res/css/views/elements/_UseCaseSelection.pcss
  • ./res/css/views/elements/_DialPadBackspaceButton.pcss
  • ./res/css/views/elements/_RoomAliasField.pcss
  • ./res/css/views/elements/_ResizeHandle.pcss; checked
  • ./res/css/views/elements/_InfoTooltip.pcss
  • ./res/css/views/elements/_InviteReason.pcss
  • ./res/css/views/elements/_SettingsFlag.pcss
  • ./res/css/views/elements/_ImageView.pcss
  • ./res/css/views/elements/_ManageIntegsButton.pcss Remove obsolete CSS files - _AuthButtons.pcss, _NewSessionReviewDialog.pcss, and _ManageIntegsButton.pcss matrix-org/matrix-react-sdk#10753
  • ./res/css/views/elements/_Slider.pcss
  • ./res/css/views/elements/_CopyableText.pcss
  • ./res/css/views/elements/_EditableItemList.pcss
  • ./res/css/views/elements/_QRCode.pcss
  • ./res/css/views/elements/_StyledRadioButton.pcss
  • ./res/css/views/elements/_LabelledCheckbox.pcss
  • ./res/css/views/elements/_Validation.pcss
  • ./res/css/views/elements/_Dropdown.pcss
  • ./res/css/views/elements/_TextWithTooltip.pcss
  • ./res/css/views/elements/_SSOButtons.pcss
  • ./res/css/views/elements/_AccessibleButton.pcss
  • ./res/css/views/elements/_InteractiveTooltip.pcss
  • ./res/css/views/elements/_Pill.pcss
  • ./res/css/views/elements/_ReplyChain.pcss
  • ./res/css/views/elements/_ExternalLink.pcss
  • ./res/css/views/elements/_FacePile.pcss
  • ./res/css/views/location/_LocationPicker.pcss
  • ./res/css/views/avatars/_DecoratedRoomAvatar.pcss
  • ./res/css/views/avatars/_BaseAvatar.pcss
  • ./res/css/views/avatars/_WidgetAvatar.pcss
  • ./res/css/views/dialogs/_DevtoolsDialog.pcss
  • ./res/css/views/dialogs/_RoomSettingsDialogBridges.pcss
  • ./res/css/views/dialogs/_ShareDialog.pcss
  • ./res/css/views/dialogs/_ChatCreateOrReuseChatDialog.pcss
  • ./res/css/views/dialogs/_CompoundDialog.pcss
  • ./res/css/views/dialogs/_LocationViewDialog.pcss
  • ./res/css/views/dialogs/_SpotlightDialog.pcss
  • ./res/css/views/dialogs/_SlashCommandHelpDialog.pcss
  • ./res/css/views/dialogs/_GenericFeatureFeedbackDialog.pcss
  • ./res/css/views/dialogs/_JoinRuleDropdown.pcss
  • ./res/css/views/dialogs/_AppDownloadDialog.pcss
  • ./res/css/views/dialogs/_SettingsDialog.pcss
  • ./res/css/views/dialogs/_AddExistingToSpaceDialog.pcss
  • ./res/css/views/dialogs/_ConfirmSpaceUserActionDialog.pcss
  • ./res/css/views/dialogs/_InviteDialog.pcss
  • ./res/css/views/dialogs/security/_CreateCrossSigningDialog.pcss
  • ./res/css/views/dialogs/security/_RestoreKeyBackupDialog.pcss
  • ./res/css/views/dialogs/security/_CreateSecretStorageDialog.pcss
  • ./res/css/views/dialogs/security/_CreateKeyBackupDialog.pcss
  • ./res/css/views/dialogs/security/_KeyBackupFailedDialog.pcss
  • ./res/css/views/dialogs/security/_AccessSecretStorageDialog.pcss
  • ./res/css/views/dialogs/_WidgetCapabilitiesPromptDialog.pcss
  • ./res/css/views/dialogs/_UploadConfirmDialog.pcss
  • ./res/css/views/dialogs/_ChangelogDialog.pcss
  • ./res/css/views/dialogs/_SpaceSettingsDialog.pcss
  • ./res/css/views/dialogs/_TermsDialog.pcss
  • ./res/css/views/dialogs/_PollCreateDialog.pcss
  • ./res/css/views/dialogs/_ManageRestrictedJoinRuleDialog.pcss
  • ./res/css/views/dialogs/_LeaveSpaceDialog.pcss
  • ./res/css/views/dialogs/_SetEmailDialog.pcss
  • ./res/css/views/dialogs/_ConfirmUserActionDialog.pcss
  • ./res/css/views/dialogs/_DeactivateAccountDialog.pcss
  • ./res/css/views/dialogs/_ModalWidgetDialog.pcss
  • ./res/css/views/dialogs/_FeedbackDialog.pcss
  • ./res/css/views/dialogs/_RoomUpgradeDialog.pcss
  • ./res/css/views/dialogs/_SpacePreferencesDialog.pcss
  • ./res/css/views/dialogs/_VerifyEMailDialog.pcss
  • ./res/css/views/dialogs/_IncomingSasDialog.pcss
  • ./res/css/views/dialogs/_NewSessionReviewDialog.pcss Remove obsolete CSS files - _AuthButtons.pcss, _NewSessionReviewDialog.pcss, and _ManageIntegsButton.pcss matrix-org/matrix-react-sdk#10753
  • ./res/css/views/dialogs/_RoomSettingsDialog.pcss
  • ./res/css/views/dialogs/_CreateRoomDialog.pcss
  • ./res/css/views/dialogs/_ServerPickerDialog.pcss
  • ./res/css/views/dialogs/_UntrustedDeviceDialog.pcss
  • ./res/css/views/dialogs/_BulkRedactDialog.pcss
  • ./res/css/views/dialogs/_AnalyticsLearnMoreDialog.pcss
  • ./res/css/views/dialogs/_BugReportDialog.pcss
  • ./res/css/views/dialogs/_CreateSubspaceDialog.pcss
  • ./res/css/views/dialogs/_MessageEditHistoryDialog.pcss
  • ./res/css/views/dialogs/_RoomUpgradeWarningDialog.pcss
  • ./res/css/views/dialogs/_ServerOfflineDialog.pcss
  • ./res/css/views/dialogs/_ForwardDialog.pcss
  • ./res/css/views/dialogs/_UserSettingsDialog.pcss
  • ./res/css/views/dialogs/_ExportDialog.pcss
  • ./res/css/views/dialogs/_RegistrationEmailPromptDialog.pcss
  • ./res/css/_font-weights.pcss
  • ./res/css/_common.pcss
  • ./res/css/_font-sizes.pcss
  • ./res/css/voice-broadcast/atoms/_VoiceBroadcastRoomSubtitle.pcss
  • ./res/css/voice-broadcast/atoms/_PlaybackControlButton.pcss
  • ./res/css/voice-broadcast/atoms/_VoiceBroadcastControl.pcss
  • ./res/css/voice-broadcast/atoms/_VoiceBroadcastRecordingConnectionError.pcss
  • ./res/css/voice-broadcast/atoms/_VoiceBroadcastHeader.pcss
  • ./res/css/voice-broadcast/atoms/_LiveBadge.pcss
  • ./res/css/voice-broadcast/molecules/_VoiceBroadcastBody.pcss
  • ./res/css/compound/_Icon.pcss
  • ./res/css/compound/_SuccessDialog.pcss
  • ./res/css/_animations.pcss
This was referenced May 1, 2023
Merged
Merged
@Johennes Johennes added the Help Wanted Extra attention is needed label Oct 24, 2023
@Johennes
Copy link
Contributor

Thanks for reporting this. Given that this will need to be an ongoing effort, I think we should first explore automated tooling for finding dead CSS. Therefore, I'm closing this in favor of #23067.

@Johennes Johennes closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Developer-Experience Help Wanted Extra attention is needed T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@germain-gg @Johennes @luixxiul