Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing on "Help & About" tab seems not right #25442

Open
luixxiul opened this issue May 25, 2023 · 5 comments
Open

Spacing on "Help & About" tab seems not right #25442

luixxiul opened this issue May 25, 2023 · 5 comments
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect

Comments

@luixxiul
Copy link

luixxiul commented May 25, 2023

Steps to reproduce

  1. Open "Help & About" tab

Outcome

What did you expect?

Sections should be split with spacing, so that elements in them can be perceived as grouped.

What happened instead?

  • The gaps between the texts and buttons seem wide, which is almost enough to give perception that buttons are not in the same group as the text above. This is why Keyboard shortcuts button, which is not clear by itself that it belongs to FAQ section, seems a little bit out of order ("Does it belong to FAQ, or is it on the same level as the headers?").
  • The gaps between the headers and the rectangle about version information, the list, and Homeserver address seem wide, and it is perceived as if texts to describe the section lacked there.

Screenshot from 2023-05-25 15-46-41

It is recommended to check on the actual UI since the screenshot above does not express the actual spacing on the monitor.

For comparison, this is a cropped screenshot of the same tab on 1.11.31. Here it is possible to see which items are grouped to which section clearly, though there is not consistency of spacing code-wise.

Screenshot from 2023-05-25 15-46-10

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

No response

Homeserver

No response

Will you send logs?

No

@kerryarchibald
Copy link
Contributor

Spacing is as defined in design
Further design tweaks should be addressed by Compound

@luixxiul
Copy link
Author

Spacing is as defined in design

(The design is not public; you need to log in to Figma.)

@weeman1337
Copy link
Contributor

I would say we should just use the same spacing as in the new device manager

image

„Show QR code“ in the screenshot above.

@weeman1337 weeman1337 added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels May 30, 2023
@manancodes
Copy link

manancodes commented Sep 28, 2023

Every group has 3 components.
A heading, a description and Content, and description is not present in every group.

Description has a margin top of 8px. (Distance from the heading)
Content has a margin top of 24px. (Distance from heading or description if present)
This is consistent in all the pages with similar components.

Screenshot 2023-09-29 at 1 26 20 AM

Content having a margin of 24px is too much. Using 14px makes things much better. In the image below, 14px is used.

Screenshot 2023-09-29 at 1 32 07 AM

How should I move forward with this?

@manancodes
Copy link

@weeman1337 @luixxiul @kerryarchibald Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants