Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the focus indicator is extremely ugly #25563

Open
Kommynct opened this issue Jun 12, 2023 · 4 comments
Open

the focus indicator is extremely ugly #25563

Kommynct opened this issue Jun 12, 2023 · 4 comments

Comments

@Kommynct
Copy link

Kommynct commented Jun 12, 2023

Your use case

I would like to either disable it, or make the focus indicator change based on the element that is in focus, instead of it being global the focus should be per-selector, for example, a better focus indicator for rooms would be highlighting the background (like when you hover), almost globally the hover indicator would look better

@t3chguy
Copy link
Member

t3chguy commented Jun 14, 2023

@gsouquet are Compound elements having focus indicators designed for them?

@germain-gg
Copy link
Contributor

Yes. We have focus indicators for all elements in Compound.

I appreciate that the current design might not be to your taste but it is very unlikely we will provide an option to disable focus highlighting.

make the focus indicator change based on the element that is in focus

Could you elaborate on the above, I believe this is already the case as elements have an orange outline to hint their focused state.

a better focus indicator for rooms would be highlighting the background

Unfortunately only changing the background will not meet accessibility requirements https://www.w3.org/WAI/WCAG21/Understanding/use-of-color.html

@Kommynct
Copy link
Author

Kommynct commented Jun 14, 2023

Ahh, didn't think of accessibility requirements, I don't want them disabled, I just thought they could be better integrated into the UI, but if it'll cause accessibility issues, I understand, i'm going to give a few examples of looking wonky though:

image

Around your avatar, it should be a circle if the avatars are circular:
image

and when there's an expand button it doesn't properly surround it:
image

@germain-gg
Copy link
Contributor

I fully agree with you on the examples shown above. It looks subpar and should be treated as defect and fixed to have a more aesthetically pleasing output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants