Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notices have lost their opacity layer #25826

Closed
turt2live opened this issue Jul 19, 2023 · 2 comments
Closed

Notices have lost their opacity layer #25826

turt2live opened this issue Jul 19, 2023 · 2 comments
Labels

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. Send a notice with some custom markup, such as from a bot

Outcome

What did you expect?

Opacity to dull the message contents, like in the old design:

image

What happened instead?

image

The green text is vibrant (unexpected) and the room pill is less translucent (also unexpected)

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023071901 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No

@germain-gg
Copy link
Contributor

Relying on opacity has created a class of issues regarding color contrast and accessibility so we're diverging from that.

Notices is now using --cpd-color-text-secondary (see https://compound.element.io/?path=/docs/tokens-semantic-colors--docs) which is sufficiently different from the primary events who you to be able to distinguish them.

Same goes for the pills, as it'd make matter worst for cases like #22134

@germain-gg germain-gg closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2023
@t3chguy
Copy link
Member

t3chguy commented Jul 20, 2023

the primary events who you to be able to distinguish them.

Only if they don't specify a colour using data-mx-color or font color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants