Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar colours just disappeared #26155

Closed
Salamandar opened this issue Sep 12, 2023 · 12 comments · Fixed by matrix-org/matrix-react-sdk#11604
Closed

Avatar colours just disappeared #26155

Salamandar opened this issue Sep 12, 2023 · 12 comments · Fixed by matrix-org/matrix-react-sdk#11604
Assignees
Labels
A11y A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker Z-Compound Z-Platform-Specific

Comments

@Salamandar
Copy link
Contributor

Steps to reproduce

Starting with today's update (1.11.41), avatar colours (for people not having an actual avatar) just disappeared.

All avatars are the usual letter on a gray background.

In the message list : (username is coloured)
Capture d’écran du 2023-09-12 22-46-00

In the rooms list : (username is base color)
Capture d’écran du 2023-09-12 22-46-05

Outcome

What did you expect?

The usual colours used for the avatar placeholder.

What happened instead?

Grey.

Operating system

Archlinux

Browser information

Firefox 115

URL for webapp

app.element.io

Application version

Version de Element : 1.11.41 Version de Olm : 3.2.14

Homeserver

matrix.org

Will you send logs?

No

@ManuelHu
Copy link

Just some investigation I just did (see #26042):
Toggling layout.css.has-selector.enabled in Firefox's about:config "fixes" the issue. Firefox is currently the only mainstream browser not supporting the CSS :has() selector.

And this selector is used to style the avatar in element 1.11.41.

This has been fixed in element-hq/compound-web@1361a4a, but apparently did not make it into the release :-/

On develop.element.io the fix is already available.

@CsatiZoltan
Copy link

@ManuelHu On develop.element.io, the colours have come back, but they are different.

@t3chguy t3chguy self-assigned this Sep 13, 2023
@t3chguy t3chguy added Z-Platform-Specific X-Regression X-Release-Blocker A-Avatar A11y Z-Compound S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 13, 2023
@andybalaam
Copy link
Contributor

Fixed in 1.11.42

@CsatiZoltan
Copy link

Indeed fixed. Just a question: why did you change the colours of the icons?

@andybalaam
Copy link
Contributor

Indeed fixed. Just a question: why did you change the colours of the icons?

We're changing over lots of parts of the app to use the Compound design system. In this case, the change of colours is to make us consistent with the Element mobile apps.

@Salamandar
Copy link
Contributor Author

Salamandar commented Sep 13, 2023

Indeed fixed. Just a question: why did you change the colours of the icons?

We're changing over lots of parts of the app to use the Compound design system. In this case, the change of colours is to make us consistent with the Element mobile apps.

It is now less consistent today with Element Android : The letter is now coloured and the round is now darker than before. (tested on Firefox and Chrome)

TBH I would love to have the colours of the round and the letter swapped : the round of the "standard" colour (the same as the username), and the letter a bit darker, like Signal does.

@Salamandar
Copy link
Contributor Author

Salamandar commented Sep 13, 2023

Indeed fixed. Just a question: why did you change the colours of the icons?

We're changing over lots of parts of the app to use the Compound design system. In this case, the change of colours is to make us consistent with the Element mobile apps.

Then the current UI is not compliant with the Compound design system.
See : https://compound.element.io/?path=%2Fstory%2Fcompound-web_avatar--no-image-fallback

(And, funny enough, my suggestion of a darker letter on a lighter round background matches with the Compound design system :D )

@WolfspiritM
Copy link

WolfspiritM commented Sep 13, 2023

Am I the only one who doesn't like the idea of the colors changing? My color is completely different now and in conversations I always think I've a new message. Especially confusing is that a friend has now a similar color I had before and I have now a color he had before.

Blue just became purple and purple became blue for example...

Couldn't you've just kept at least a similar color and just made it more faded?

I still hope that there will be a way to set a custom color someday...

( Talking about the text above the message and not the round circle )

@CsatiZoltan
Copy link

It became significantly less visible on dark theme. In my case, the former pink icon became this:
new_icon

@andybalaam
Copy link
Contributor

I'm going to ask one of the designers to look into this. Thanks for the feedback.

@andybalaam
Copy link
Contributor

Response: we think the current behaviour does comply with the design system, and would welcome people logging a new issue if you find specific places where it doesn't. Thanks again!

@Salamandar
Copy link
Contributor Author

Thanks @andybalaam .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-Avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker Z-Compound Z-Platform-Specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants