Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: Remove "Upgrade your encryption" flow #27455

Open
richvdh opened this issue May 9, 2024 · 1 comment
Open

Element-R: Remove "Upgrade your encryption" flow #27455

richvdh opened this issue May 9, 2024 · 1 comment
Labels
A-E2EE A-E2EE-Key-Backup A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented May 9, 2024

If we detect that you have key backup, but no 4S, we pop up a toast prompting you to "Upgrade your encryption".

This is broken in several ways:

Frankly, I don't think this is a flow we should be supporting at all. We should remove the "upgrade your encryption" flow. However, if it's something that we want to keep, then it needs tests and we need to fix the bugs above.

@richvdh richvdh added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE-Key-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely A-Element-R Issues affecting the port of Element's crypto layer to Rust labels May 9, 2024
@dosubot dosubot bot added the A-E2EE label May 9, 2024
@richvdh richvdh changed the title Element-R: "Upgrade your encryption" flow is broken Element-R: Remove "Upgrade your encryption" flow May 13, 2024
@richvdh
Copy link
Member Author

richvdh commented May 13, 2024

After discussion with the team today: we're agreed that this flow should be removed altogether. When logging into an account that has key backup but the keys for that backup are not available in 4S, the only option will be to create a new key backup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-E2EE-Key-Backup A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

1 participant