Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: withheld messages are no longer shown as such #27653

Open
richvdh opened this issue Jun 27, 2024 · 1 comment
Open

Element-R: withheld messages are no longer shown as such #27653

richvdh opened this issue Jun 27, 2024 · 1 comment
Labels
A-E2EE A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-UISI Unable to decrypt errors

Comments

@richvdh
Copy link
Member

richvdh commented Jun 27, 2024

If the sender chooses to only send e2e messages to verified devices, then unverified devices will receive a notification of a withheld key. (Specifically, a to-device message of type m.room_key.withheld with a code of m.unverified or m.blacklisted.)

We should reflect these notifications in the UI, rather than just showing a generic "Unable to decrypt message" error. (This used to work with legacy crypto, but has not been re-implemented for Rust Crypto).

We should also give them a different error code in the Posthog analytics, so that they can be treated as "expected UTDs".
@richvdh richvdh added Z-UISI Unable to decrypt errors A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect A-E2EE S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jun 27, 2024
@richvdh richvdh mentioned this issue Jun 27, 2024
Open
@dosubot dosubot bot added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 27, 2024
@richvdh richvdh removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jun 27, 2024
@andybalaam
Copy link
Contributor

Added to top of backlog because:

  • it is a quick win
  • it is UTD+Trust+WebR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression Z-UISI Unable to decrypt errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andybalaam @richvdh @t3chguy