Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Races in device list update logic #3126

Closed
richvdh opened this issue Feb 3, 2017 · 2 comments
Closed

Races in device list update logic #3126

richvdh opened this issue Feb 3, 2017 · 2 comments
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Feb 3, 2017

  1. at sync token 1, we get a notification that alice has updated her devices, and start a request to update them
  2. at sync token 2, we get a notification that bob has updated his devices, and start a request to update them
  3. the request for bob's devices completes, so we consider ourselves to be up-to-date to token 2.
  4. we restart the app
  5. we have an outdated list of alice's devices, but no way to tell that.
@richvdh
Copy link
Member Author

richvdh commented Feb 3, 2017

The easy solution here is to limit ourselves to one update request in flight.

@ara4n ara4n added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 9, 2017
@richvdh
Copy link
Member Author

richvdh commented Feb 13, 2017

Another one:

  1. After initial sync (sync token 1, say), but before the /changes query completes, the user initiates a device query for Bob (eg by looking at their memberinfo).
  2. That completes; we consider ourselves to be up-to-date to token 1.
  3. Still before /changes completes, or before the resulting /query completes, we restart the app
  4. We may have many outdated device lists, but no way to tell that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

2 participants