Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State event redaction: Riot web continues to display redacted data #3214

Open
manuroe opened this issue Feb 13, 2017 · 4 comments
Open

State event redaction: Riot web continues to display redacted data #3214

manuroe opened this issue Feb 13, 2017 · 4 comments
Labels
A-Redaction A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@manuroe
Copy link
Member

manuroe commented Feb 13, 2017

Consider the following scenario:

  • @manolo:matrix.org changes his displayname from Manolo to Manolo2 (event1)
  • @manolo:matrix.org changes his displayname to Manolo3 (event2)
  • @manolo:matrix.org redacts event1.

No more information about event1 should be displayed. But Riot web continues to display the string "Manolo2" :

After a page refresh, and a full initial sync, Riot web display is correct:

On a state event redaction, Riot web should consider to make a room initial sync request to get it the display right without needing of refreshing the page.
@manuroe
Copy link
Member Author

manuroe commented Feb 13, 2017

Android and iOS manage this by doing room initial sync. Not sure there is a better solution to handle this use case.

@ara4n
Copy link
Member

ara4n commented Feb 18, 2017

we need to fix this in general by improving the stores so that redactions actually redact everywhere.

@ara4n ara4n added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Timeline labels Feb 18, 2017
@ara4n ara4n mentioned this issue Feb 19, 2017
Closed
@ara4n
Copy link
Member

ara4n commented Feb 19, 2017

#2869 had great examples of this.

@richvdh richvdh mentioned this issue Mar 22, 2017
Closed
@turt2live turt2live mentioned this issue Mar 30, 2018
Closed
@auscompgeek auscompgeek mentioned this issue Jul 15, 2020
Closed
@auscompgeek
Copy link

This made it annoying to attempt to figure out what was happening in #14468 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Redaction A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@auscompgeek @jryans @ara4n @manuroe