Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons to jump back and forth through pics when in lightbox viewer #337

Open
matrixbot opened this issue Nov 6, 2015 · 10 comments
Open
Labels
A-Light-Box UI when viewing an image A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@matrixbot
Copy link

matrixbot commented Nov 6, 2015

Created by @ matthew:matrix.org.

Should also be able to use left & right arrows

@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@ara4n ara4n removed this from the Ragnarok milestone Apr 13, 2016
@t3chguy t3chguy changed the title left & right arrows should jump back and forth through pics when in lightbox viewer buttons to jump back and forth through pics when in lightbox viewer Apr 16, 2020
@tschopo
Copy link

tschopo commented Feb 9, 2021

Yes! Since scrolling is broken in rooms with a lot of images (jumping around and reloading), this would be a nice workaround.

@SimonBrandner
Copy link
Contributor

Related to #13

@ara4n
Copy link
Member

ara4n commented Nov 13, 2021

This would be an easy and fun high-impact issue for someone to help with.

@ara4n ara4n added the Help Wanted Extra attention is needed label Nov 13, 2021
@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely A-Media and removed P3 labels Nov 13, 2021
@kittykat kittykat added X-Needs-Design and removed Help Wanted Extra attention is needed labels Jan 17, 2022
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Papercuts Visible. Impactful. Predictable to action. labels Jan 17, 2022
@Snamhdaen
Copy link

I must say, I'm a bit embarrassed by the fact that I opened the umpteenth issue concerning this feature request. Although, in fairness I think the fact that this issues gets "reopened" every month underlines both the demand by the community and the slight obscurity of the title wording. I did try to search for similar issues but this one did not turn up. Maybe change "pics" to "pictures"?

Unfortunately, I won't be of much help in pushing this issue forward. Out of curiosity: Would a readaptation from the (rather nice) implementation of this feature in the android app be very complicated?

@t3chguy
Copy link
Member

t3chguy commented Mar 8, 2022

Out of curiosity: Would a readaptation from the (rather nice) implementation of this feature in the android app be very complicated?

Given there is 0 code shared between the platforms, yes

@robintown robintown self-assigned this Mar 16, 2022
@robintown
Copy link
Member

Would we be happy with only being able to jump through the images in the current timeline, or do we want the same seshat magic that the file panel uses, for infinite back-pagination?

@robintown robintown reopened this Mar 21, 2022
@robintown robintown added the X-Needs-Product More input needed from the Product team label Mar 21, 2022
@robintown robintown removed their assignment Apr 8, 2022
@kittykat
Copy link
Contributor

kittykat commented Oct 5, 2022

We do want this feature from a product POV, but it does need design input and thinking about accessibility.

@kittykat kittykat removed the X-Needs-Product More input needed from the Product team label Oct 5, 2022
@MurzNN
Copy link
Contributor

MurzNN commented Oct 5, 2022

And when we implement the galleries feature by the element-hq/roadmap#13 - those buttons seem should be converted from the global list to the per-gallery list.

@kittykat
Copy link
Contributor

kittykat commented Oct 5, 2022

To be honest, as a user, I would prefer if they cycled through all attached images even when images could be grouped for sending.

From a product pov, we need to do some research and gather user feedback on what behaviour would be better received.

@beposec
Copy link

beposec commented Apr 10, 2023

Any progress here? As @ara4n mentioned this is a high-impact issue. Why is it still not implemented after 7 years?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Light-Box UI when viewing an image A-Media O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Development

No branches or pull requests