Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin to the right of read receipts is misaligned, as is the MELS collapse button (regression) #3396

Closed
ara4n opened this issue Mar 9, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#770
Assignees
Milestone

Comments

@ara4n
Copy link
Member

ara4n commented Mar 9, 2017

This is a regression. On /app:

screen shot 2017-03-09 at 17 10 45

On /develop:

screen shot 2017-03-09 at 17 10 35

The margin between RRs and the RHS of the timeline has got way too big - probably also causing #3384. Please can we be super-careful about introducing cosmetic regressions like this.

Meanwhile, the MELS 'collapse' button has the correct margin (but is then unaligned with the RRs). I assume the reason to put the MELS collapse button on the RHS is to let you quickly toggle them on & off, as they'd be replaced by a Collapse button which is in the same place... except in practice when you click it, the button typically jumps upwards on the page due to the scroll lock. So I'd be quite inclined to put it back where it was in the first place - i.e. inline in the MELS. Which presumably might also fix the CSS which is causing the original issue here.

@lampholder lampholder added this to the Riot web next release milestone Mar 27, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 27, 2017

It looks like the RRs are off to the left by the width of one RR. I've confirmed this. The fix is simple, I shall PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants