Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mentioning multiple people should change the : to a comma #4883

Open
t3chguy opened this issue Aug 25, 2017 · 8 comments
Open

mentioning multiple people should change the : to a comma #4883

t3chguy opened this issue Aug 25, 2017 · 8 comments
Assignees
@t3chguy
Labels
A-Composer Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Regression Z-t3chguy

Comments

@t3chguy
Copy link
Member

t3chguy commented Aug 25, 2017

No description provided.

@lampholder
Copy link
Member

This would be really nice to have :)

@lukebarnard1
Copy link
Contributor

This is a regression afaik because the old composer had this

@t3chguy
Copy link
Member Author

t3chguy commented Aug 29, 2017

TIL

@lampholder lampholder mentioned this issue Sep 27, 2017
Closed
@t3chguy t3chguy mentioned this issue Jan 20, 2018
Closed
@turt2live turt2live mentioned this issue Dec 27, 2019
Closed
@t3chguy t3chguy self-assigned this Jan 22, 2020
@t3chguy t3chguy added this to In Progress in Web App Team via automation Jan 22, 2020
@t3chguy t3chguy removed this from In Progress in Web App Team Jan 22, 2020
@t3chguy t3chguy removed their assignment Jan 22, 2020
@t3chguy
Copy link
Member Author

t3chguy commented Jan 22, 2020

This turns out to be longer than the 15m job I expected it to be due to the autocomplete path having no context of the previous parts in the composer model, it only gets handed an index. Gonna push this back to another time

@yannicka
Copy link

Could the solution be not to add the ":" in the first place?

@t3chguy
Copy link
Member Author

t3chguy commented Nov 28, 2020

It could, but that behaviour is intended and desirable.

@t3chguy t3chguy mentioned this issue Apr 12, 2021
Merged
@yannicka
Copy link

This is related to #16682.

@SimonBrandner SimonBrandner added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed P3 labels Aug 29, 2021
@ShadowJonathan
Copy link
Contributor

ShadowJonathan commented Aug 29, 2021 •
edited
Loading

I also think https://github.com/matrix-org/matrix-doc/issues/3303 is related

@ShadowJonathan ShadowJonathan mentioned this issue Aug 31, 2021
Merged
@t3chguy t3chguy self-assigned this Nov 29, 2021
@t3chguy t3chguy mentioned this issue Nov 29, 2021
Closed
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist Help Wanted Extra attention is needed labels Jun 10, 2022
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Composer Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Regression Z-t3chguy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

When mentioning multiple people use comma delimiter between them matrix-org/matrix-react-sdk
10 participants
@kittykat @jryans @Johennes @lampholder @t3chguy @aaronraimist @lukebarnard1 @ShadowJonathan @yannicka @SimonBrandner