Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol emoji aren't made big #5050

Closed
dbkr opened this issue Sep 15, 2017 · 5 comments
Closed

Symbol emoji aren't made big #5050

dbkr opened this issue Sep 15, 2017 · 5 comments
Labels
A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Sep 15, 2017

Apparently emojione's regex doesn't count symbols in the 'miscellaneous symbols' or 'dingbats' ranges, eg. ✉︎ and ☺︎ even though it has graphics for them.

@dbkr
Copy link
Member Author

dbkr commented Sep 15, 2017

I think this is related to #5049 as it's the emojione regex matching the symbol character when the actual emoji is the symbol character plus a variant

plain symbol: ☺ (works)
symbol + variant: ☺︎ (fails)

@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Timeline S-Tolerable Low/no impact on users labels Sep 22, 2017
@pafcu
Copy link
Contributor

pafcu commented Oct 10, 2017

This does not actually seem to be a bug but a feature. The non-working emoji uses variant 15 which explicitly means that it is to be treated as text, not an emoji. Using variant 16 (explicitly emoji) works as expected. In fact, the bug seems to be that the text-version is emojified at all (replaced by an image).

@turt2live
Copy link
Member

We'll need to consider this as part of #9281

@turt2live turt2live mentioned this issue Mar 26, 2019
1 task
@bwindels
Copy link
Contributor

Seems to work on #9281, the above mentioned characters render as:
image

@ara4n
Copy link
Member

ara4n commented May 21, 2019

\o/

@ara4n ara4n closed this as completed May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants