Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roomsetting to strip HTML colours (as bridged from IRC) #5424

Open
ara4n opened this issue Oct 24, 2017 · 8 comments
Open

roomsetting to strip HTML colours (as bridged from IRC) #5424

ara4n opened this issue Oct 24, 2017 · 8 comments
Labels
A11y good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement

Comments

@ara4n
Copy link
Member

ara4n commented Oct 24, 2017

We need to have ability to strip HTML colors, because in some cases it extremely reduces text legibility, see linked issue below. Suggested solution to solve this issue is to add a generic config option, so you can manually turn off irc-like text coloring on demand.

Edited to add details.
First issue describing problems: #9366

@t3chguy
Copy link
Member

t3chguy commented Oct 24, 2017

+10000000

@t3chguy
Copy link
Member

t3chguy commented Oct 24, 2017

/me adds to 70 issue long todo list

@ara4n
Copy link
Member Author

ara4n commented Oct 24, 2017

this is a particularly good candidate for granular settings, too - given you might want to enforce it for a room, or for an account, or even for a device (if devices have different themes).

@t3chguy
Copy link
Member

t3chguy commented Oct 28, 2017

Should this be just font colour attr or also 'data-mx-bg-color', 'data-mx-color'
as bridged from IRC implies just the colour attr, but the other two are other ways of sneaking colour in, that won't enter via the bridge

@Palid Palid added A11y O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P2 labels Aug 12, 2021
@Palid Palid added this to Backlog (Unsorted) in Web App Team Aug 12, 2021
@Palid Palid removed this from Backlog (Unsorted) in Web App Team Aug 25, 2021
@turt2live turt2live added Help Wanted Extra attention is needed good first issue Good for newcomers labels May 13, 2022
@genofire
Copy link

genofire commented Mar 2, 2023

is there away to send different colors for light and dark themes?
e.g. for light themes, darkblue and for dark theme lightblue?

this is not readable on an element with dark theme enabled:

<font color="blue">Info</font>

@t3chguy
Copy link
Member

t3chguy commented Mar 2, 2023

No, that is not something the Matrix spec allows @genofire - but it does allow setting a foreground and background colour so you can ensure legibility.

@genofire
Copy link

genofire commented Mar 2, 2023

Hmm, should element render "default" colors dedicated by light and dark mode?
e.g. send-color: <font color="{{ sendColor}}">Info</font>

send-color light-theme dark-theme comment
red red red always good readable
blue blue lightblue
green darkgreen green
yellow orange yellow

@t3chguy
Copy link
Member

t3chguy commented Mar 2, 2023

that wouldn't work with custom themes, where someone's background might be red or blue or pink or whatever e.g. https://github.com/aaronraimist/element-themes

@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Enhancement
Projects
None yet
Development

No branches or pull requests

8 participants