Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read receipts should appear on the last visible event instead of disappearing into the ether #5761

Closed
turt2live opened this issue Dec 1, 2017 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3056
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Description

Here's a screenshot from #riot:
image

In this screenshot, Matthew sent a message and has not read anything (as far as I can tell). Doing a bit of investigation, I can see that Matthew's read receipt is at $1512163962601724BjrBV:matrix.org which happens to be this event:

synapse=# select event_id, room_id, type, content from events where event_id = '$1512163962601724BjrBV:matrix.org';
             event_id              |            room_id             |             type             |      content
-----------------------------------+--------------------------------+------------------------------+-------------------
 $1512163962601724BjrBV:matrix.org | !DgvjtOljKujDBrxyHk:matrix.org | org.matrix.room.preview_urls | {"disable":false}
(1 row)

That particular event happens to fit in between Matthew's message and my first message. Matthew's read receipt should probably still appear on his original message as Riot has no way of communicating to the user that there's a hidden event, and missing read receipts feels buggy.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 62
  • OS: Windows 10
  • URL: riot.im/develop
@uhoreg
Copy link
Member

uhoreg commented Dec 4, 2017

see also: #3511 and #948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants