Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When viewing a community (GroupView mounted), 3x requests are done than are necessary #5901

Closed
lukebarnard1 opened this issue Jan 2, 2018 · 2 comments · Fixed by matrix-org/matrix-react-sdk#1709
Closed

When viewing a community (GroupView mounted), 3x requests are done than are necessary #5901

lukebarnard1 opened this issue Jan 2, 2018 · 2 comments · Fixed by matrix-org/matrix-react-sdk#1709
Labels
A-Performance A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jan 2, 2018 •
edited

Specifically, the requests done 3 times (by GroupStore) are:

  • /summary
  • /rooms
  • /users
  • /invited_users

(with the prefix r0/groups/%2Bgroup%3Adomain.com/)
@lukebarnard1 lukebarnard1 changed the title When opening a community, 3x requests are done than are necessary When viewing a community (GroupView mounted), 3x requests are done than are necessary Jan 2, 2018
@turt2live
Copy link
Member

related: #5899

@lukebarnard1
Copy link
Contributor Author

I'd argue for them being unrelated - #5899 would be the FlairStore doing something weird whilst calling /profile.

@lampholder lampholder added T-Defect A-Performance P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Spaces Spaces, groups, communities labels Jan 12, 2018
@lukebarnard1 lukebarnard1 mentioned this issue Jan 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Performance A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix group store redundant requests matrix-org/matrix-react-sdk
3 participants
@turt2live @lampholder @lukebarnard1