Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking to see how big of a problem LL with limited sync responses are in practice #7327

Closed
bwindels opened this issue Sep 12, 2018 · 2 comments
Labels
A-Lazy-Loading P1 T-Task Tasks for the team like planning
Milestone

Comments

@bwindels
Copy link
Contributor

add some tracking as described below:

so:
Matthew to add metrics on synapse to track how many sync responses are limited, and how many membership events they contain. I expect this to look like "incr sync for 40 rooms, 30 gaps, sent 243054 member events" in the synapse logs

meanwhile, we want to see just how slow incremental syncs are (in terms of the server processing & network bandwidth) time on the clients in general, for which we don't have metrics
i suggest we track on clients:

  • time taken for initial /sync and incr /sync to return
  • how many membership events there are, and how many rooms were limited?
  • how long it takes to process the /sync result

in the short term, I'll disable LL on incremental syncs entirely, and so fix the bug like that
and then once we've gathered metrics from both server & clients, we can decide what the correct solution actually based on the data, where are options are:

  • sync /members every time there's a gappy sync
  • give up on LL for incre sync
  • pass a since= param to /members (or use /sync) to keep the members list updated.

does that match everyone's understanding from the call just then?

@bwindels
Copy link
Contributor Author

@ara4n is this still needed? I recall you mentioning the other day you already got some insight by logging this server-side?

@bwindels bwindels moved this from Not Started to In Progress in Web App Team Sep 20, 2018
@lampholder lampholder added T-Task Tasks for the team like planning P1 labels Sep 27, 2018
@lampholder lampholder added this to the RW014 milestone Sep 27, 2018
@bwindels bwindels moved this from In Progress to Not Started in Web App Team Oct 9, 2018
@bwindels
Copy link
Contributor Author

bwindels commented Oct 9, 2018

We're parking this for now, more important things to do

@bwindels bwindels closed this as completed Oct 9, 2018
@bwindels bwindels moved this from Not Started to Done in Web App Team Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Lazy-Loading P1 T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

2 participants