Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to peek into invites #807

Closed
AmandineLP opened this issue Jan 28, 2016 · 10 comments
Closed

Ability to peek into invites #807

AmandineLP opened this issue Jan 28, 2016 · 10 comments
Labels
A-Invite P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Spec-Changes

Comments

@AmandineLP
Copy link
Contributor

I invited a user already registered using his email and later his matrix ID but he couldn't peek despite the setting being turned on

@AmandineLP AmandineLP added P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 28, 2016
@AmandineLP AmandineLP added this to the v0 - Friendly Beta milestone Jan 28, 2016
@ara4n
Copy link
Member

ara4n commented Feb 14, 2016

@AmandineLP any idea what flow they were trying to use to peek?

@ara4n ara4n added the T-Defect label Feb 14, 2016
@AmandineLP
Copy link
Contributor Author

I just reproduced it on /beta clicking on the invite. I just get the "would you like to accept or decline the invite" msg. but I cna't see history despite the room being peekable.

@ara4n
Copy link
Member

ara4n commented Feb 18, 2016

So we deliberately don't let people peek into invites yet. We do let people peek when they explicitly join rooms, but given the problems we're seeing there I'd like to get that stable first before we open up a whole new level of complexity with this. Going to bump it to v1.

The relevant code is:

https://github.com/matrix-org/matrix-react-sdk/blob/9a0ea56bba49fb6324a199b55c02cc11662e48f0/src/components/structures/RoomView.js#L1492

@ara4n
Copy link
Member

ara4n commented Mar 14, 2016

...and bumping this to v2...

@ara4n ara4n changed the title Peeking seem broken on invite Ability to peek into invotes Mar 17, 2016
@ara4n ara4n changed the title Ability to peek into invotes Ability to peek into invites Mar 17, 2016
@ara4n
Copy link
Member

ara4n commented Mar 17, 2016

actually, this is harder than I recalled as it requires server-side stuff. We can't currently peek into arbitrary invites because we're not yet joined to the room(!)

@ara4n
Copy link
Member

ara4n commented Mar 17, 2016

filed as SPEC-368

@ara4n
Copy link
Member

ara4n commented Apr 13, 2016

This would also stop us having send invite stale metadata snapshots around the place for name/alias/avatar etc, as we can preview the correct live metadata for the room.

@MurzNN
Copy link
Contributor

MurzNN commented Apr 6, 2021

Wow, seems some improvement happens with this issue: matrix-org/matrix-react-sdk@f0333b5 🚀

@t3chguy
Copy link
Member

t3chguy commented Apr 12, 2021

@MurzNN nope, that is an explicit invite reason as specified by the inviter, not the ability to peek into the room.

@MadLittleMods
Copy link
Contributor

Closing in favor of element-hq/element-meta#230 which suggests a "Preview" button to avoid being shown spam from an unwanted invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invite P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Spec-Changes
Projects
None yet
Development

No branches or pull requests

6 participants