Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply text-decoration:none to anchor tags, and underline on hover #8093

Open
nadonomy opened this issue Jan 10, 2019 · 1 comment
Open

Apply text-decoration:none to anchor tags, and underline on hover #8093

nadonomy opened this issue Jan 10, 2019 · 1 comment
Labels
A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@nadonomy
Copy link
Member

nadonomy commented Jan 10, 2019 •
edited

ref https://matrix.to/#/!XIydWLOEJvcDBKwWKE:matrix.org/$15471213821570bZPLu:cadair.com?via=matrix.org&via=matrixim.cc&via=disroot.org

Edit: After further checks, this seems to be the case on /app too:

screenshot 2019-01-10 at 12 00 19

It actually feels good to be able to click on URL's, but I suspect what makes this feel off on /experimental is the unorthodox underlines. Therefore, I suggest we apply text-decoration: none to anchor tags within code blocks.
@nadonomy
Copy link
Member Author

nadonomy commented Jan 10, 2019 •
edited

Actually, we may want to apply text-decoration: none to all anchor tags; we don't use it consistently, (subjectively) it's ugly and (objectively) links have enough affordance based on context and colour.

@nadonomy nadonomy changed the title URL's inside code blocks have anchor tags Apply text-decoration:none to anchor tags, and underline on hover Jan 10, 2019
@lampholder lampholder added T-Defect ui/ux P2 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline and removed redesign labels Mar 12, 2019
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @lampholder @nadonomy