Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading a room is an easy way to desync state from the server #8136

Open
turt2live opened this issue Jan 15, 2019 · 6 comments
Open

Upgrading a room is an easy way to desync state from the server #8136

turt2live opened this issue Jan 15, 2019 · 6 comments
Labels
A-Room-Upgrades P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Cache-Confusion Related to internal cache (clearing helps / causes the issue)

Comments

@turt2live
Copy link
Member

After upgrading an internal room, many people ended up with one of two (or one then the other) problems with the room:

  • Sending messages were unencrypted (indication of the client not seeing the state event). Receiving encrypted messages was fine.
  • The room name was "Someone and N others" instead of the actual name (indication of the state event going missing).

Some people had to clear cache & reload multiple times.

This is almost certainly a duplicate of some other issue, however it is being reported for tracking that it can easily happen upon room upgrade. The room being encrypted may have nothing to do with this.

@lampholder
Copy link
Member

@turt2live is this a redesign issue?

@turt2live
Copy link
Member Author

I've flagged it as one because people on experimental had problems. I have not verified what app or develop does, but would expect the same.

@turt2live turt2live changed the title Upgrading an encrypted room resulted in bad room state cache in the new room Upgrading a room is an easy way to desync state from the server Mar 14, 2019
@turt2live turt2live added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Room-Upgrades and removed redesign labels Mar 14, 2019
@turt2live
Copy link
Member Author

I think this is a subset of #7843 however an extremely easy way to reproduce it. Using this as the canonical "I upgraded a room and now everything looks broken" bug.

@turt2live turt2live added this to Raging Inferno 🔥🔥🔥 in Web App Team Mar 14, 2019
@turt2live
Copy link
Member Author

Other symptoms people report:

  • Lack of room name after upgrade
  • Lack of merging in the room list
  • Lack of "go back" button to see old room
  • Lack of tombstone

@turt2live turt2live self-assigned this Mar 19, 2019
@turt2live turt2live moved this from Raging Inferno 🔥🔥🔥 to In Progress in Web App Team Mar 19, 2019
@turt2live
Copy link
Member Author

I haven't really been able to reproduce this in a monitored setting, and decided to go looking at known rageshakes to see what comes up. General report is available here on the sister issue: #7843 (comment)

@turt2live
Copy link
Member Author

Right, it's been 2.5 days of trying to figure out how to cause this reliably enough to debug it with no luck. If someone is unlucky enough to encounter this or #7843, please rageshake.

@turt2live turt2live removed this from In Progress in Web App Team Mar 22, 2019
@turt2live turt2live removed their assignment Mar 22, 2019
@jryans jryans added the Z-Cache-Confusion Related to internal cache (clearing helps / causes the issue) label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-Upgrades P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Cache-Confusion Related to internal cache (clearing helps / causes the issue)
Projects
None yet
Development

No branches or pull requests

4 participants