Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration should also do .well-known discovery #8309

Open
jryans opened this issue Jan 29, 2019 · 5 comments
Open

Registration should also do .well-known discovery #8309

jryans opened this issue Jan 29, 2019 · 5 comments

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 29, 2019

Currently, we only do .well-known server discovery for the login flow. We should also do it on registration to give a similar UX to both flows.

@turt2live
Copy link
Member

@jryans I assume this is the configuration side? Or is this some future UX that I probably forgot about?

@turt2live turt2live added the X-Needs-Info This issue is blocked awaiting information from the reporter label Apr 11, 2019
@turt2live turt2live self-assigned this Apr 11, 2019
@jryans
Copy link
Collaborator Author

jryans commented Apr 11, 2019

I believe this is about entering a full MXID (@bob:server.name).

On login, entering a full MXID triggers .well-known discovery and changes the server to the discovery result. On registration, we currently don't do the same thing. Since the login vs. registration UX looks very similar, entering a full MXID should also trigger .well-known discovery and change the server on registration as well.

It's possible some Riot admins will want to lock down registration to only their default HS, but that's a separate concern from what should be possible on Riot by default. It should be possible to easily login and register to any HS from any Riot (assuming the Riot instance allows it via config, which it would by default).

@lampholder Does that sound correct to you?

@turt2live
Copy link
Member

bump @lampholder

@lampholder
Copy link
Member

I've overthought the hell out of this, and I've finally convinced myself it falls into the category of "coming to a decision I have confidence in is more faff than it's worth".

(The complexity fwiw exists mostly in the space of how we want users to experience onboarding, what we want to train our users about mxids and how much we want to encourage users typing their credentials in to riot-like things on the internet).

I conclude: the symmetry would be nice to have, but the frequency with which users register and login itself is not symmetric, so I don't think implementing the .well-known lookup for registration is as valuable as it was for login. So I think we can do this and worry about config/default config later, but I don't see it as a high priority change.

@turt2live
Copy link
Member

I somehow missed your reply, but it sounds like this is a p3 feature, so flagging it as that and moving on.

@turt2live turt2live added the P3 label May 14, 2019
@turt2live turt2live removed their assignment May 14, 2019
@t3chguy t3chguy self-assigned this Nov 17, 2020
@richvdh richvdh removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Jan 12, 2023
@t3chguy t3chguy removed their assignment Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants