Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending email invite to the same person after they've already accepted it does not use their MXID #8489

Closed
turt2live opened this issue Feb 8, 2019 · 4 comments
Closed

Sending email invite to the same person after they've already accepted it does not use their MXID #8489

turt2live opened this issue Feb 8, 2019 · 4 comments
Labels
A-3PIDs A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Community-Testing

Comments

@turt2live
Copy link
Member

  1. Invite friend@example.org
  2. Friend accepts invite, associating the email with their account
  3. Invite friend@example.org to another room
  4. Friend receives another email (wrong behaviour: should invite the Matrix user)
@lampholder
Copy link
Member

Does this have to be in the same room? Did Friend already have a matrix account?

@lampholder lampholder added X-Needs-Info This issue is blocked awaiting information from the reporter A-Invite T-Defect and removed redesign labels Mar 14, 2019
@turt2live
Copy link
Member Author

Different rooms. I'm not sure if it matters if Friend had an account previously, but they did before step 1 and just added the email to their account in this case.

@lampholder lampholder added P1 A-3PIDs and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Apr 30, 2019
This was referenced Jul 12, 2020
Closed
Closed
@kittykat
Copy link
Contributor

Recent discussion in (I think) Delight channel was that there should probably be a check about when user last logged in stale accounts are pinged by email and recently used accounts are not.

Needs re-testing with two emails to an existing account (no emails should be sent atm) and two emails to addresses which are not associated with accounts.

@turt2live turt2live added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P1 labels Jun 13, 2022
@t3chguy
Copy link
Member

t3chguy commented Sep 26, 2022

Closing in favour of #23353

@t3chguy t3chguy closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-3PIDs A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Community-Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kittykat @turt2live @lampholder @t3chguy