Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unencrypted messages in encrypted rooms should not look the same as unverified messages #9114

Open
aaronraimist opened this issue Mar 11, 2019 · 4 comments
Assignees
Labels
A-E2EE A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Design

Comments

@aaronraimist
Copy link
Collaborator

aaronraimist commented Mar 11, 2019

They need a different design (other than just on hover)

They should get a different icon

@lampholder
Copy link
Member

Screenshots really help with triaging issues like this - I've tweaked the bug templates to try and encourage more screenshots :)

Unencrypted:
image

Unverified:
image

So they look different, but if you have always show encryption icons disabed in user settings, you'll only see the difference on hover.
image

There should be different styling for these two types of messages. Even better, the always show encryption icons option should be replaced - I'd argue that instead of offering users a cosmetic choice as to whether they see these icons or not, we should be:

  • making the same information available in a way that minimises visual clutter
  • making the display of that information optional, so users who aren't interested in encryption/verifiable device ownership etc. aren't needlessly overwealmed with crypto UX.k;l

@lampholder lampholder added T-Defect ui/ux P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline X-Needs-Design labels Mar 15, 2019
@aaronraimist
Copy link
Collaborator Author

Whoops yeah. I think this was a !github create though.

The point of this issue I think was just to say that there should be a separate icon for unencrypted messages because the "!" icon, even if red vs gray, looks very similar unless you hover over it.

I wish the !github create command automatically included a link to the conversation but I believe I filed this because someone was confused as to why they were being sent unencrypted messages in an encrypted room (the other user was on Riot Android I believe). I was never able to really figure out if they were actually getting sent unencrypted messages or they just misunderstood what this icon meant. I think maybe we should go back to something like an unlocked icon 🔓 for unencrypted messages in encrypted rooms rather than reusing the same icon that we use for unverified.

@aaronraimist
Copy link
Collaborator Author

aaronraimist commented Feb 11, 2020

Screen Shot 2020-02-10 at 6 50 39 PM

image

This is even worse now. Martin's bottom screenshot is Riot web which experienced some bug and is sending unencrypted messages in an encrypted room. If you don't hover over the icon it looks exactly like you are sending encrypted but unverified messages when he is actually sending unencrypted messages.

Screen Shot 2020-02-10 at 6 51 27 PM

@aaronraimist
Copy link
Collaborator Author

These still use the same icon

@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely A-E2EE and removed P1 labels Dec 18, 2021
@gaelledel gaelledel self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Design
Projects
None yet
Development

No branches or pull requests

5 participants