Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to hide join/parts entirely #916

Closed
matrixbot opened this issue Feb 11, 2016 · 11 comments
Closed

option to hide join/parts entirely #916

matrixbot opened this issue Feb 11, 2016 · 11 comments
Assignees

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.

@fuzzy76
Copy link

fuzzy76 commented Nov 17, 2016

Would love this. Getting mentioned 24 hours ago in a busy bridged IRC channel makes for a terrible session of scrolling to find the context. Hiding joins/parts for those channels would help a lot.

@richvdh
Copy link
Member

richvdh commented Mar 3, 2017

might want to hide changes of avatars/displayname too.

@Chaos99
Copy link

Chaos99 commented Mar 24, 2017

While I'm fully behind this and duplicated it in #3476, isn't the focus unnecessary small here?
If you are going to implement any filter stage for messages before display, why not make it customizable in the first place? Just let the user add regex for the message data fields they want to see/not see per room.
(With some templates like joins/leaves/name changes).

@t3chguy
Copy link
Member

t3chguy commented May 6, 2017

I have started on this, got the filtering stage hooked up to a new part of UserSettingsStore, just need to make the UI for its settings now.

@Chaos99 with the structure of a Matrix event I think regex would not be a very good method, plus when filtering a large amounts of event it could introduce delay
The way I've done it so far allows you to hide any arbitrary eventType or msgType

@ara4n
Copy link
Member

ara4n commented May 30, 2017

@t3chguy is this on a branch somewhere? @kegsay may be able to pick it up today

@ara4n ara4n assigned t3chguy and kegsay and unassigned t3chguy May 30, 2017
@ara4n ara4n added P1 and removed P2 labels May 30, 2017
@t3chguy
Copy link
Member

t3chguy commented May 30, 2017

eeeeergh, this might be on an old working directory on my external hdd
/me looks

edit: it so appears that I never pushed it to gh and was lost in my PC nuking :(

@kegsay
Copy link
Contributor

kegsay commented May 31, 2017

Taking this on.

@kegsay kegsay removed their assignment Jun 8, 2017
@kegsay
Copy link
Contributor

kegsay commented Jun 8, 2017

Dropping this - it's not a quick win at all. See matrix-org/matrix-react-sdk@fc93517 for what I did and what doesn't work.

@t3chguy t3chguy self-assigned this Jun 8, 2017
@t3chguy
Copy link
Member

t3chguy commented Jun 8, 2017

I guess its back to me :P

@grahamperrin
Copy link

https://riot.im/develop/ looks better, to me, with the recent improvements – thanks, folks 👍

@t3chguy
Copy link
Member

t3chguy commented Jul 30, 2017

@grahamperrin thanks! but it may have introduced some bugs, so please keep your eye out and report anything weird

Thanks!

@t3chguy t3chguy closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants