Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish posts of media and text content in order of initial sending (not in order of finished uploads) #9234

Open
r4dh4l opened this issue Mar 21, 2019 · 4 comments
Open

Publish posts of media and text content in order of initial sending (not in order of finished uploads) #9234

r4dh4l opened this issue Mar 21, 2019 · 4 comments
Labels
A-Timeline Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect Z-t3chguy

Comments

@r4dh4l
Copy link

r4dh4l commented Mar 21, 2019 •
edited

Description

If I post mixed content of pictures and text messages I have to wait until a picture is uploaded before I can post a comment below it if I want to keep the intended order (first picture, then text) - otherwise the comment will be posted above/before the picture even the picture upload was initiated before sending the text.

Steps to reproduce

  1. Upload a picture in a room.
  2. While the picture is being uploaded post a text. The text will be published above/earlier than the picture post.

Describe how what happens differs from what you expected.

The order of appearance should be the order of posting content. So when I upload something I want that everything I posted after initiating the upload will be posted after the upload is finished, not before (like now).

Version information

  • Platform: desktop

For the desktop app:

  • OS: GNU/Linux Debian
  • Version: 1.0.4
@r4dh4l r4dh4l changed the title Publish posts of media and text content in room in order of sending Publish posts of media and text content in order of sending Mar 21, 2019
@r4dh4l r4dh4l changed the title Publish posts of media and text content in order of sending Publish posts of media and text content in order of initial sending (not when it is completely uploaded) Mar 21, 2019
@r4dh4l r4dh4l changed the title Publish posts of media and text content in order of initial sending (not when it is completely uploaded) Publish posts of media and text content in order of initial sending (not in order of finished uploads) Mar 21, 2019
@jryans jryans added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline type:composer labels Mar 21, 2019
@turt2live turt2live mentioned this issue Dec 27, 2019
Closed
@t3chguy t3chguy mentioned this issue Dec 27, 2019
Merged
@t3chguy
Copy link
Member

t3chguy commented Dec 27, 2019

The above PR serializes file uploads, but messages after file uploads will not await them yet

@t3chguy
Copy link
Member

t3chguy commented Apr 11, 2020 •
edited

Note for future me.

afterwards, this promBefore thing can be discarded: https://github.com/matrix-org/matrix-react-sdk/blob/fde32f13a5b684549f8c99dcedda4b6031b56088/src/ContentMessages.js#L446

@jryans jryans removed the defect label Mar 4, 2021
@t3chguy t3chguy mentioned this issue Jul 28, 2021
Open
@t3chguy t3chguy mentioned this issue Mar 8, 2022
Open
@turt2live turt2live added S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P1 labels Apr 27, 2022
@turt2live
Copy link
Member

We're slowly building up more cases where we need a more general queue for not-yet-sent events (eg: voice message drafts), ftr.

@turt2live turt2live added the Help Wanted Extra attention is needed label Apr 27, 2022
@MadLittleMods
Copy link
Contributor

Related to:

@MadLittleMods MadLittleMods mentioned this issue Feb 15, 2023
Closed
@Johennes Johennes added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround S-Tolerable Low/no impact on users T-Defect Z-t3chguy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jryans @MadLittleMods @Johennes @turt2live @t3chguy @r4dh4l