Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and / or unify event shown utilities #9948

Open
jryans opened this issue Jun 4, 2019 · 1 comment
Open

Document and / or unify event shown utilities #9948

jryans opened this issue Jun 4, 2019 · 1 comment
Labels
P2 T-Task Tasks for the team like planning

Comments

@jryans
Copy link
Collaborator

jryans commented Jun 4, 2019

We have at least 3 similar functions all serving related but not identical goals:

  • _shouldShowEvent in MessagePanel instances
    • This calls haveTileForEvent and shouldHideEvent plus a few extra tweaks
    • This is the closest to how we decide which events are actually shown
  • EventTile.haveTileForEvent
  • shouldHideEvent

It's a bit confusing to keep track of which one to edit for any given situation. I think we should at least try to document where each of these is used today and / or unify them if possible in the future to reduce confusion.
@jryans jryans added T-Task Tasks for the team like planning P2 labels Jun 4, 2019
@jryans jryans mentioned this issue Jun 4, 2019
Merged
@jryans
Copy link
Collaborator Author

jryans commented Jul 2, 2019

eventTriggersUnreadCount is also peripherally related to these as well.

@jryans jryans mentioned this issue Jul 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jryans