Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links are not clickable anymore (newest nightly) #1111

Closed
noantiq opened this issue Aug 22, 2023 · 1 comment · Fixed by #1115
Closed

Links are not clickable anymore (newest nightly) #1111

noantiq opened this issue Aug 22, 2023 · 1 comment · Fixed by #1115
Assignees
@jmartinesp
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@noantiq
Copy link

noantiq commented Aug 22, 2023

Steps to reproduce

  1. Installed newest nightly build via Firebase App Distribution/ App Tester
  2. Open a chat and click on a link

Outcome

What did you expect?

Link is opened in my browser

What happened instead?

The link is styled as expected but nothing happens on click. The message bubble just lights up like every other that is clicked.

May be related to #1079 that I found in the change log (?)

Your phone model

Pixel 6

Operating system version

Android 13

Application version and app store

0.1.4-nightly (40001040) from this morning (Aug 22, 2023 at 6:29 AM)

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No
@noantiq noantiq added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 22, 2023
@jmartinesp jmartinesp added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Aug 22, 2023
@jmartinesp
Copy link
Contributor

May be related to #1079 that I found in the change log (?)

Yes, it's definitely caused by that PR, sorry about that.

@jmartinesp jmartinesp mentioned this issue Aug 22, 2023
Merged
@jmartinesp jmartinesp self-assigned this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make links in messages clickable again element-hq/element-x-android
2 participants
@jmartinesp @noantiq