[Poll] Render ended poll and improve UI in the timeline #1113
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1113 +/- ##
===========================================
+ Coverage 57.06% 57.17% +0.11%
===========================================
Files 1022 1021 -1
Lines 26266 26175 -91
Branches 5307 5322 +15
===========================================
- Hits 14988 14965 -23
+ Misses 8969 8890 -79
- Partials 2309 2320 +11
☔ View full report in Codecov by Sentry. |
| RadioButton(selected = false, onClick = {}) | ||
| RadioButton(selected = false, enabled = false, onClick = {}) | ||
| } | ||
| Row(horizontalArrangement = Arrangement.spacedBy(6.dp)) { |
There was a problem hiding this comment.
Actually, these were used so the designers could take a quick look in Showkase and verify the buttons look good in all possible states by looking at a single preview. Could we go back to displaying the 4 states at the same time?
If we want the interaction to work, we could use selected = checked in the first 2 components and selected = !checked in the next two?
There was a problem hiding this comment.
Done, I have an issue with the interactive mode on the RadioButton preview but the interaction works fine in Showkase
There was a problem hiding this comment.
(I just triggered the screenshots action)
|
Kudos, SonarCloud Quality Gate passed! |
Florian14
deleted the
feature/fre/improve_poll_event_timeline_rendering
branch
Successor of #1031 and continue element-hq/element-meta#1830
Content
Note:
Screenshots
poll_timeline_demo.webm