Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to react/forward/reply on a reply message #1232

Closed
thefirstofthe300 opened this issue Sep 6, 2023 · 4 comments · Fixed by #1327
Closed

Unable to react/forward/reply on a reply message #1232

thefirstofthe300 opened this issue Sep 6, 2023 · 4 comments · Fixed by #1327
Assignees
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish Z-UI-UX

Comments

@thefirstofthe300
Copy link

Steps to reproduce

  1. Long click on a reply message
  2. Note that the dialog with the reply/forward/copy/reactions does not open

Outcome

What did you expect?

I expected the reply/forward/copy/reactions dialog to open

Your phone model

Pixel 7 Pro

Operating system version

Android 13

Application version and app store

Element X version 1.5 from Play Store

Homeserver

Synapse 1.91.1

Will you send logs?

No

Are you willing to provide a PR?

No

@thefirstofthe300 thefirstofthe300 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Sep 6, 2023
@bmarty
Copy link
Member

bmarty commented Sep 6, 2023

Thanks for reporting. You have to long click on the reply itself to open the bottom sheet dialog, and not the message it's been replied to.

We may want to handle click on the replied message to navigate the the original message at some point, this is not supported yet SDK side (it's permalink navigation), and maybe handle custom action for long click as well.

In the mean time, I agree that the long click should probably open the bottom sheet.

@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Timeline Z-UI-UX labels Sep 6, 2023
@thefirstofthe300
Copy link
Author

Thanks for reporting. You have to long click on the reply itself to open the bottom sheet dialog, and not the message it's been replied to.

I tried that before opening this bug. No matter where on the reply I attempt to long click, nothing happens.

I just tried to reproduce again on 0.1.6 Play Store and was still seeing this behavior. I tried on a relatively large reply message so I know for a fact I'm not clicking on the original message.

@rom4nik
Copy link
Contributor

rom4nik commented Sep 7, 2023

It seems that in replies long press doesn't work when applied to multi-line text "hitboxes", touching elsewhere on the message bubble (except for preview of original message) works. See below:

menu.mp4

@thefirstofthe300
Copy link
Author

Excellent catch. That video does describe exactly what I'm seeing although I didn't realize it. I too can confirm touching anywhere on the reply message text doesn't activate the dialog but touching anywhere in the message where there isn't text does seem to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish Z-UI-UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants