New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rich text editor] Add feature flag for rich text editor #1289
Conversation
var enableTextFormatting by remember { mutableStateOf(true) } | ||
LaunchedEffect(Unit) { | ||
enableTextFormatting = featureFlagService.isFeatureEnabled(FeatureFlags.RichTextEditor) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming reflects that the rich text editor is not actually toggled; it is still always running under the hood. Only the text formatting capabilities of the RTE may be disabled (i.e. HTML output ignored and formatting buttons hidden)
afcdf24
to
06ac18d
Compare
|
06ac18d
to
99fd079
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1289 +/- ##
========================================
Coverage 57.69% 57.69%
========================================
Files 1087 1087
Lines 28618 28643 +25
Branches 5861 5865 +4
========================================
+ Hits 16510 16526 +16
- Misses 9535 9542 +7
- Partials 2573 2575 +2
☔ View full report in Codecov by Sentry. |
99fd079
to
b584996
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Type of change
Content
Add feature flag for the rich text editor.
When the feature flag is disabled, markdown support is enabled.
Motivation and context
Screenshots / GIFs
Screen_recording_20230912_174836.webm
Tests
Tested devices
Checklist