Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing padding (regression from the Bloom effect) #1297

Closed
bmarty opened this issue Sep 13, 2023 · 0 comments · Fixed by #1299
Closed

Missing padding (regression from the Bloom effect) #1297

bmarty opened this issue Sep 13, 2023 · 0 comments · Fixed by #1299
Assignees
@jmartinesp
Labels
A-Room List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Bloom Effect Z-UI-UX

Comments

@bmarty
Copy link
Member

bmarty commented Sep 13, 2023

  • Put the phone in airplane mode
  • Launch the app
  • We cannot see the top of the screen
expected (observed when entering airplane mode when the app is resumed) actual
image image

Also, maybe the offline banner should be transparent to let the bloom effect visible. FTR this is the rendering when the phone has network:

image
@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely Z-UI-UX A-Room List Z-Bloom Effect labels Sep 13, 2023
@jmartinesp jmartinesp mentioned this issue Sep 13, 2023
Merged
14 tasks
@jmartinesp jmartinesp self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinesp jmartinesp

Labels
A-Room List O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Bloom Effect Z-UI-UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix top padding in room list when app is opened in offline mode element-hq/element-x-android
2 participants
@jmartinesp @bmarty