Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only download content.json from Localazy. #2031

Merged
merged 2 commits into from Dec 14, 2023
Merged

Only download content.json from Localazy. #2031

merged 2 commits into from Dec 14, 2023

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Dec 14, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR tweaks the localazy script to only convert files inside of content.json.

Motivation and context

As part of element-hq/element-x-ios#2100 I'm going to try and add an InfoPlist.json so that we can translate our system alert prompts on iOS, and don't want this to affect Android. I think this simple filtering should be enough for each project to add any specific files that they require.

Screenshots / GIFs

Tests

  • Run tools/localazy/downloadStrings.sh --all and see that it still works 馃檲

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@pixlwave pixlwave requested a review from a team as a code owner December 14, 2023 16:05
@pixlwave pixlwave requested review from bmarty and removed request for a team December 14, 2023 16:05
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for being pro-active!
Everything is still working fine according to my tests.

@bmarty bmarty merged commit 1af6bbb into element-hq:develop Dec 14, 2023
10 of 11 checks passed
@pixlwave pixlwave deleted the doug/localazy-files branch December 14, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants