Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited bubble broken #2060

Closed
VolkerJunginger opened this issue Dec 19, 2023 · 11 comments · Fixed by #2075 or #2272
Closed

Edited bubble broken #2060

VolkerJunginger opened this issue Dec 19, 2023 · 11 comments · Fixed by #2075 or #2272
Assignees
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@VolkerJunginger
Copy link

Steps to reproduce

Create a text message. Edit it. You'll see that the "Edited" hint & the text overlaps.

While testing it last week (cw50) worked already in an older build.

Outcome

What did you expect?

What happened instead?

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes

@VolkerJunginger VolkerJunginger added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Dec 19, 2023
@bmarty
Copy link
Member

bmarty commented Dec 19, 2023

@VolkerJunginger I cannot repro, but maybe not searching in the right direction. Can you attach a screenshot to the issue please?

@bmarty bmarty added the X-Needs-Info This issue is blocked awaiting information from the reporter label Dec 19, 2023
@VolkerJunginger
Copy link
Author

image-20231219-122606

@VolkerJunginger
Copy link
Author

see 2nd and third message.

@jmartinesp
Copy link
Contributor

The way how this works was slightly changed when we replaced the rendering of text timeline messages and added mentions, but maybe it was enough to break this.

@bmarty
Copy link
Member

bmarty commented Dec 20, 2023

(maybe due to the German word for edited which is longer, but I think we measure the translated word)

@jmartinesp jmartinesp self-assigned this Dec 20, 2023
@jmartinesp jmartinesp added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Dec 20, 2023
@jmartinesp
Copy link
Contributor

Technically, the best solution would be to edit the RTE library to be able to have an onTextLayout callback and use something like this, but in the meanwhile I'll add a fix for the current 'add NBSP chars' solution.

@VolkerJunginger
Copy link
Author

bug is still there w. nightly from 21.12.

@jmartinesp
Copy link
Contributor

It seems to work fine for me in German in the last nightly:

Screenshot

Can you share an example of a case where it doesn't work?

@manuroe
Copy link
Member

manuroe commented Jan 3, 2024

@VolkerJunginger can you check it again?

@VolkerJunginger
Copy link
Author

Screenshot_20240122-090058

It is still broken.

@jmartinesp
Copy link
Contributor

jmartinesp commented Jan 22, 2024

Not for me:

image

There may be some corner case that causes the issue, but we haven't seen it anywhere else, so I don't think that's the case.

Are you sure you're using the latest version?

Oh, I just reproduced it. It has to be edited in the EXA app and the previous text must be close to the timestamp. When this happens, for some reason the bubble doesn't resize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
4 participants