Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected UTDs due to membership support #2754

Merged
merged 10 commits into from
Apr 30, 2024

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Apr 25, 2024

Fixes https://github.com/element-hq/crypto-internal/issues/220
Fixes https://github.com/element-hq/crypto-internal/issues/222

Draft as based on this rust-sdk PR matrix-org/matrix-rust-sdk#3337

UTD of room with shared history will be presented as:
image

And the error will be reported to posthog with a newly created code from matrix-analytics-event 0.20

Includes a new string created in localazy.

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@ElementBot
Copy link
Collaborator

ElementBot commented Apr 25, 2024

Warnings
⚠️

gradle/libs.versions.toml#L17 - A newer version of androidx.activity:activity-compose than 1.8.2 is available: 1.9.0

Generated by 🚫 dangerJS against cf9f2c0

@BillCarsonFr BillCarsonFr force-pushed the feature/valere/expected_utd_integration branch from 36f4c85 to f65025f Compare April 26, 2024 15:24
Copy link
Contributor

github-actions bot commented Apr 26, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/dxwXeP

@BillCarsonFr BillCarsonFr marked this pull request as ready for review April 30, 2024 07:34
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner April 30, 2024 07:34
@BillCarsonFr BillCarsonFr requested review from jmartinesp and removed request for a team April 30, 2024 07:34
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 30, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Apr 30, 2024
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. The CI is recording the new screenshot.

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.61%. Comparing base (27b91c2) to head (cf9f2c0).
Report is 6 commits behind head on develop.

Files Patch % Lines
...odel/event/TimelineItemEncryptedContentProvider.kt 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2754      +/-   ##
===========================================
+ Coverage    73.60%   73.61%   +0.01%     
===========================================
  Files         1504     1506       +2     
  Lines        36058    36079      +21     
  Branches      6957     6959       +2     
===========================================
+ Hits         26539    26561      +22     
+ Misses        5870     5869       -1     
  Partials      3649     3649              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 60c8d6e into develop Apr 30, 2024
16 checks passed
@bmarty bmarty deleted the feature/valere/expected_utd_integration branch April 30, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants