Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get synapse/ to pass mypy #11271

Open
matrixbot opened this issue Dec 19, 2023 · 0 comments
Open

Get synapse/ to pass mypy #11271

matrixbot opened this issue Dec 19, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 19, 2023

This issue has been migrated from #11271.


Our mypy configuration currently includes an explicit enumeration of files to check. That list covers 409 of the 491 Python files in the synapse/ directory.

We should:

  • Get as many of those to pass as possible
  • Invert the selection criteria so that all files in synapse/ are checked by default, while failing files are explicitly excluded.

As of 4249082, the omitted files are:

  • storage/databases/__init__.py
  • storage/databases/main/cache.py
  • storage/schema/* (25 files)

We should probably start with switching from inclusion to exclusion, and burn down from there. Note that the next release of mypy will have significantly better syntax for multiple exclusions, but it's not out yet, so we'll have to get by with gnarlier regex-based syntax.

(Edited 2022-08-30 by dmr to reflect the status quo.)

@matrixbot matrixbot changed the title Dummy issue Get synapse/ to pass mypy Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant