Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restrictions on routing /messages requests to workers #11717

Open
matrixbot opened this issue Dec 19, 2023 · 0 comments
Open

Remove restrictions on routing /messages requests to workers #11717

matrixbot opened this issue Dec 19, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 19, 2023

This issue has been migrated from #11717.


From workers.md:

Pagination requests can also be handled, but all requests for a given room must be routed to the same instance. Additionally, care must be taken to ensure that the purge history admin API is not used while pagination requests for the room are in flight

This is to ensure that multiple /backfill requests don't happen for the same room concurrently, and that we don't cause confusion by backfilling content that is currently being purged.

To relax this requirement we would need to replace the in-process locks with cross-process locks. We have some such basic locks already for the federation inbound event queues that we could probably reuse

@matrixbot matrixbot changed the title Dummy issue Remove restrictions on routing /messages requests to workers Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant