Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long running schema deltas are killed by systemd and lead to bootlooping #14401

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments
Open

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023

This issue has been migrated from #14401.


When a schema delta takes too long, Synapse will get restarted by systemd, possibly repeatedly.

~~When using postgres, schema deltas are transactional. Synapse will run the schema delta and time out again. ~~
When using sqlite, schema deltas are not fully transactional (see docstring here). The schema delta will end up being half applied and the database will end up in an inconsistent state. Depending on the nature of the schema delta, the next run may fail. Tracked in #14909.

This manifested as:

Things we may consider doing:

  • Write some docs?
  • Increase the timeout?
  • Pretend to be alive while running schema deltas?
  • dmr: Make sqlite schema deltas transactional too? Tracked in Dummy issue #14909.
@matrixbot matrixbot changed the title Dummy issue Long running schema deltas are killed by systemd and lead to bootlooping Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant