Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize MSC4041 support (Retry-After header) #16944

Closed
clokep opened this issue Feb 20, 2024 · 0 comments · Fixed by #16947
Closed

Stabilize MSC4041 support (Retry-After header) #16944

clokep opened this issue Feb 20, 2024 · 0 comments · Fixed by #16947

Comments

@clokep
Copy link
Contributor

clokep commented Feb 20, 2024

MSC4041 has passed FCP and can be stabilized in Synapse.

See matrix-org/synapse#16136 for the initial implementation.

The steps to do this are:

  1. Remove the changes in synapse/config/experimental.py to set LimitExceededError.include_retry_after_header.
  2. Remove the LimitExceededError.include_retry_after_header flag (and default to it being enabled always).
  3. Update the tests at tests/api/test_errors.py and tests/rest/client/test_login.py.

That should be all that's necessary, but some other tests could break due to this. It should be a fully backwards compatible change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize support for Retry-After header (MSC4014) clokep/synapse
1 participant
@clokep