Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [cascader] checkbox sync error #11462

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

acyza
Copy link
Contributor

@acyza acyza commented Feb 7, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

为了减少#4443 所说的对性能的影响,给checkbox需要响应式的情况单独套上reactive

fixed #11435

@pull-request-triage
Copy link

👋 @acyza, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Hello @acyza, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🧪 Playground Preview: https://element-plus.run/?pr=11462
Please comment the example via this playground if needed.

@acyza

This comment was marked as outdated.

@acyza

This comment was marked as outdated.

@acyza

This comment was marked as outdated.

@acyza

This comment was marked as outdated.

@acyza acyza changed the title fix(components): [cascader] sync error fix(components): [cascader] checkbox sync error Feb 15, 2023
@acyza acyza closed this Feb 15, 2023
@acyza acyza reopened this Feb 15, 2023
@btea btea requested a review from chenxch July 31, 2023 14:05
@exherb
Copy link
Contributor

exherb commented Aug 1, 2023

Is this will merge into the next release?

@btea
Copy link
Collaborator

btea commented Aug 1, 2023

@exherb Don't worry, other members are needed to review.

@btea btea merged commit 69dcee0 into element-plus:dev Aug 2, 2023
18 of 19 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
* fix(components): [cascader] sync error

* fix(components): [cascader] checkbox sync error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [cascader] cascader组件回显问题
4 participants