Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [notification] fix props.zIndex lose efficacy bug #12474

Merged
merged 6 commits into from
May 24, 2023
Merged

fix(components): [notification] fix props.zIndex lose efficacy bug #12474

merged 6 commits into from
May 24, 2023

Conversation

Gnalvin
Copy link
Contributor

@Gnalvin Gnalvin commented Apr 16, 2023

option zIndex for notification can't effect

@pull-request-triage
Copy link

👋 @Ganlvin, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 16, 2023
@github-actions
Copy link

github-actions bot commented Apr 16, 2023 •
edited

@github-actions
Copy link

Hello @Ganlvin, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 18, 2023
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12474
Please comment the example via this playground if needed.

jtejederabit
jtejederabit reviewed Apr 18, 2023
View reviewed changes
Copy link

@jtejederabit jtejederabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Gnalvin Gnalvin requested a review from tolking May 5, 2023 08:47
@Gnalvin Gnalvin requested a review from tolking May 6, 2023 05:10
@tolking tolking mentioned this pull request May 24, 2023
Closed
3 tasks
@btea btea merged commit 9b564c3 into element-plus:dev May 24, 2023
10 checks passed
This was referenced May 24, 2023
Closed
Merged
@element-bot element-bot mentioned this pull request Jun 2, 2023
Merged
3 tasks
@Gnalvin Gnalvin deleted the fix_notification_zIndex branch July 1, 2023 13:52
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@Gnalvin @dannyhebertbell
fix(components): [notification] fix props.zIndex lose efficacy bug (e…
7cf4361 
…lement-plus#12474)

* fix(components): [notification] fix props.zIndex lose efficacy bug

* fix(components): [notification] fix props.zIndex lose efficacy bug

* fix(components): [notification] fix props.zIndex lose efficacy bug

* fix(components): [notification] fix props.zIndex lose efficacy bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtejederabit jtejederabit jtejederabit left review comments

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@Gnalvin Gnalvin

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gnalvin @tolking @btea @jtejederabit