Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [focus-trap] Fixed the function that removed the listener #13158

Merged
merged 2 commits into from
Jul 22, 2023
Merged

fix(components): [focus-trap] Fixed the function that removed the listener #13158

merged 2 commits into from
Jul 22, 2023

Conversation

qiYuei
Copy link
Contributor

@qiYuei qiYuei commented Jun 9, 2023 •
edited

correct-error-listening

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

Fixed the function that removed the listener

🤖 Generated by Copilot at 8b5cbd6

Fixed a bug in focus-trap.vue that prevented releasing the focus from the trap container. Changed the event listener for FOCUS_AFTER_RELEASED to use releaseOnFocus instead of trapOnFocus.

Related Issue

Fixes #13128

Explanation of Changes

🤖 Generated by Copilot at 8b5cbd6

  • Fix bug where focus trap would not release focus on releaseFocus call (link)

fix(components): [focus-trap]
8b5cbd6 
correct-error-listening

closed element-plus#13128
@pull-request-triage
Copy link

👋 @qiYuei, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Hello @qiYuei, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 9, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 10, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13158
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented Jul 22, 2023

@qiYuei Thank you for your contribution! ❤️

@btea btea merged commit ec61c7b into element-plus:dev Jul 22, 2023
10 checks passed
@tolking tolking mentioned this pull request Jul 22, 2023
Closed
@element-bot element-bot mentioned this pull request Aug 4, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@qiYuei @dannyhebertbell
fix(components): [focus-trap] Fixed the function that removed the lis…
59b3831 
…tener (element-plus#13158)

fix(components): [focus-trap]

correct-error-listening

closed element-plus#13128

Co-authored-by: fengmingjian <fmj@hanzhisoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@qiYuei qiYuei

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [drawer] el-drawer 组件存在内存泄漏
3 participants
@qiYuei @btea @tolking