Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(components): [date-picker] export instasnce type #13618

Merged
merged 2 commits into from
Jul 29, 2023
Merged

chore(components): [date-picker] export instasnce type #13618

merged 2 commits into from
Jul 29, 2023

Conversation

makedopamine
Copy link
Contributor

@makedopamine makedopamine commented Jul 18, 2023 •
edited

closes #13586

@pull-request-triage
Copy link

👋 @makedopamine, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jul 18, 2023 •
edited

@github-actions
Copy link

Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 18, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=13618
Please comment the example via this playground if needed.

btea
btea approved these changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryuhangyeong ryuhangyeong merged commit b0258f6 into element-plus:dev Jul 29, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@makedopamine @dannyhebertbell
chore(components): [date-picker] export instasnce type (element-plus#…
f38c2f5 
…13618)

* chore(components): [date-picker] export instasnce type

* move DatePickerInstance to instance.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuhangyeong ryuhangyeong ryuhangyeong left review comments

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@makedopamine makedopamine

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [date-picker] 无法通过 InstanceType 获取 ElDatePicker 实例
4 participants
@makedopamine @tolking @btea @ryuhangyeong