Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [input] fix textarea disabled box-shadow #13632

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix(components): [input] fix textarea disabled box-shadow #13632

merged 1 commit into from
Jul 18, 2023

Conversation

shigma
Copy link
Contributor

@shigma shigma commented Jul 18, 2023 •
edited by ghost

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

97a51915463b31e0d4e8e5faf42f2558

Bug: Textarea can be hovered even if disabled.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at d625e21

  • Refactor input component styles to use CSS variables for theme customization (F0L1-F0L102)

@pull-request-triage
Copy link

👋 @shigma, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 18, 2023
@github-actions
Copy link

github-actions bot commented Jul 18, 2023 •
edited

@github-actions
Copy link

Hello @shigma, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13632
Please comment the example via this playground if needed.

ryuhangyeong
ryuhangyeong approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🎉

@btea btea merged commit 6bc7007 into element-plus:dev Jul 18, 2023
13 checks passed
@shigma shigma deleted the patch-1 branch July 18, 2023 13:29
@element-bot element-bot mentioned this pull request Aug 4, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@shigma @dannyhebertbell
fix(components): [input] fix textarea disabled box-shadow (element-pl…
2e49736 
…us#13632)

Update input.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@shigma shigma

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shigma @btea @ryuhangyeong