Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] fix for confusing click behaviour #13664

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

wuzhidexiaoming
Copy link
Contributor

@wuzhidexiaoming wuzhidexiaoming commented Jul 20, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at c198772

Fixed a bug where select dropdowns would not close properly when switching between select components. Added a check for el-tooltip-content in handleBlur function of useSelect.ts.

Related Issue

Fixes #13642.

Explanation of Changes

🤖 Generated by Copilot at c198772

  • Fix select dropdown not closing when clicking on another select component by checking focus event target in handleBlur function (link)

@pull-request-triage
Copy link

👋 @wuzhidexiaoming, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 20, 2023
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

@github-actions
Copy link

Hello @wuzhidexiaoming, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13664
Please comment the example via this playground if needed.

@tolking tolking changed the title fix(components): [select] fix for confusing click behaviour (#13642) fix(components): [select] fix for confusing click behaviour Jul 22, 2023
@tolking
Copy link
Member

tolking commented Jul 22, 2023

Thank for your contribution

@tolking tolking merged commit 05caa04 into element-plus:dev Jul 22, 2023
21 of 22 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants